Re: [Mesa-dev] [PATCH] anv: Fix L3 cache programming on Bay Trail
On Mon, Jun 19, 2017 at 11:21 AM, Francisco Jerez wrote: > Jonas Kulla writes: > > > Valid values for URBAllocation start at 32, so substract that > > before programming the register. > > > > This was missed when porting from the GL driver. > > Reviewed-by: Francisco Jerez > Reviewed-by: Jason Ekstrand And pushed with a CC to stable. Welcome to mesa-dev! --Jason > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > > index 59430a2..0216ea0 100644 > > --- a/src/intel/vulkan/genX_cmd_buffer.c > > +++ b/src/intel/vulkan/genX_cmd_buffer.c > > @@ -835,7 +835,7 @@ genX(cmd_buffer_config_l3)(struct anv_cmd_buffer > *cmd_buffer, > > anv_pack_struct(&l3cr2, GENX(L3CNTLREG2), > > .SLMEnable = has_slm, > > .URBLowBandwidth = urb_low_bw, > > - .URBAllocation = cfg->n[GEN_L3P_URB], > > + .URBAllocation = cfg->n[GEN_L3P_URB] - n0_urb, > > #if !GEN_IS_HASWELL > > .ALLAllocation = cfg->n[GEN_L3P_ALL], > > #endif > > -- > > 2.7.5 > > > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] anv: Fix L3 cache programming on Bay Trail
Jonas Kulla writes: > Valid values for URBAllocation start at 32, so substract that > before programming the register. > > This was missed when porting from the GL driver. Reviewed-by: Francisco Jerez > --- > src/intel/vulkan/genX_cmd_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index 59430a2..0216ea0 100644 > --- a/src/intel/vulkan/genX_cmd_buffer.c > +++ b/src/intel/vulkan/genX_cmd_buffer.c > @@ -835,7 +835,7 @@ genX(cmd_buffer_config_l3)(struct anv_cmd_buffer > *cmd_buffer, > anv_pack_struct(&l3cr2, GENX(L3CNTLREG2), > .SLMEnable = has_slm, > .URBLowBandwidth = urb_low_bw, > - .URBAllocation = cfg->n[GEN_L3P_URB], > + .URBAllocation = cfg->n[GEN_L3P_URB] - n0_urb, > #if !GEN_IS_HASWELL > .ALLAllocation = cfg->n[GEN_L3P_ALL], > #endif > -- > 2.7.5 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] anv: Fix L3 cache programming on Bay Trail
Valid values for URBAllocation start at 32, so substract that before programming the register. This was missed when porting from the GL driver. --- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 59430a2..0216ea0 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -835,7 +835,7 @@ genX(cmd_buffer_config_l3)(struct anv_cmd_buffer *cmd_buffer, anv_pack_struct(&l3cr2, GENX(L3CNTLREG2), .SLMEnable = has_slm, .URBLowBandwidth = urb_low_bw, - .URBAllocation = cfg->n[GEN_L3P_URB], + .URBAllocation = cfg->n[GEN_L3P_URB] - n0_urb, #if !GEN_IS_HASWELL .ALLAllocation = cfg->n[GEN_L3P_ALL], #endif -- 2.7.5 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
