Re: [Mesa-dev] [PATCH] configure.ac: pthread-stubs not present on OpenBSD
On 20 February 2018 at 10:38, Eric Engestrom wrote: > On Tuesday, 2018-02-20 17:38:00 +1100, Jonathan Gray wrote: >> pthread-stubs is no longer required on OpenBSD and has been removed. >> libpthread parts involved moved to libc. > > Similarly to the libdrm patch, I went to look for the meson.build > equivalent to fix it, but it seems to be missing... > > *BSD people, can you confirm whether pthread-stubs is still needed on > FreeBSD, DragonflyBSD and NetBSD? > Either Mesa is missing this code, or libdrm doesn't need it anymore. > I fear they won't see your question amongst the ~2k emails that mesa-dev produces ;-) Feel free to poke individual lists and/or post on mesa-maintainers. Latter is aimed for low volume distribution/platform specific topics. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] configure.ac: pthread-stubs not present on OpenBSD
On Tuesday, 2018-02-20 17:38:00 +1100, Jonathan Gray wrote: > pthread-stubs is no longer required on OpenBSD and has been removed. > libpthread parts involved moved to libc. Similarly to the libdrm patch, I went to look for the meson.build equivalent to fix it, but it seems to be missing... *BSD people, can you confirm whether pthread-stubs is still needed on FreeBSD, DragonflyBSD and NetBSD? Either Mesa is missing this code, or libdrm doesn't need it anymore. This patch itself is Reviewed-by: Eric Engestrom > > Signed-off-by: Jonathan Gray > Cc: 17.3 18.0 > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 89c5e74127..30a3377582 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -967,10 +967,10 @@ dnl In practise that should be sufficient for all > platforms, since any > dnl platforms build with GCC and Clang support the flag. > PTHREAD_LIBS="$PTHREAD_LIBS -pthread" > > -dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the > +dnl pthread-stubs is mandatory on some BSD platforms, due to the nature of > the > dnl project. Even then there's a notable issue as described in the project > README > case "$host_os" in > -linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*) > +linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu* | openbsd*) > pthread_stubs_possible="no" > ;; > * ) > -- > 2.16.0 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] configure.ac: pthread-stubs not present on OpenBSD
pthread-stubs is no longer required on OpenBSD and has been removed. libpthread parts involved moved to libc. Signed-off-by: Jonathan Gray Cc: 17.3 18.0 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 89c5e74127..30a3377582 100644 --- a/configure.ac +++ b/configure.ac @@ -967,10 +967,10 @@ dnl In practise that should be sufficient for all platforms, since any dnl platforms build with GCC and Clang support the flag. PTHREAD_LIBS="$PTHREAD_LIBS -pthread" -dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the +dnl pthread-stubs is mandatory on some BSD platforms, due to the nature of the dnl project. Even then there's a notable issue as described in the project README case "$host_os" in -linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*) +linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu* | openbsd*) pthread_stubs_possible="no" ;; * ) -- 2.16.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
