Re: [Mesa-dev] [PATCH] docs: add links to clarify patch mailing section
On Fri 26 Aug 2016, Nicholas Bishop wrote: > From: Nicholas Bishop> > * Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify > which list patches should be sent to > > * Added an explicit link to > https://lists.freedesktop.org/mailman/listinfo/mesa-dev to show > where to subscribe to the list > > * Added a link to https://git-scm.com/docs/git-send-email to help new > users of that command > > v2: add signed-off-by > Signed-off-by: Nicholas Bishop > --- > docs/devinfo.html | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Chad Versace Thanks, and pushed. One more bit of advice: When sending v2 of a patch, it's often a good idea to Cc the person (Eric) who suggested the change. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] docs: add links to clarify patch mailing section
From: Nicholas Bishop* Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify which list patches should be sent to * Added an explicit link to https://lists.freedesktop.org/mailman/listinfo/mesa-dev to show where to subscribe to the list * Added a link to https://git-scm.com/docs/git-send-email to help new users of that command v2: add signed-off-by Signed-off-by: Nicholas Bishop --- docs/devinfo.html | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index 489d263..e13837c 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -252,10 +252,14 @@ check for regressions. Mailing Patches -Patches should be sent to the Mesa mailing list for review. -When submitting a patch make sure to use git send-email rather than attaching -patches to emails. Sending patches as attachments prevents people from being -able to provide in-line review comments. +Patches should be sent to the mesa-dev mailing list for review: +https://lists.freedesktop.org/mailman/listinfo/mesa-dev;> +mesa-dev@lists.freedesktop.org. +When submitting a patch make sure to use +https://git-scm.com/docs/git-send-email;>git send-email +rather than attaching patches to emails. Sending patches as +attachments prevents people from being able to provide in-line review +comments. -- 2.7.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] docs: add links to clarify patch mailing section
On Thu, Aug 25, 2016 at 07:49:05PM -0400, Nicholas Bishop wrote: > From: Nicholas Bishop> > - Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify > which list patches should be sent to > > - Added an explicit link to > https://lists.freedesktop.org/mailman/listinfo/mesa-dev to show > where to subscribe to the list > > - Added a link to https://git-scm.com/docs/git-send-email to help new > users of that command Missing s-o-b (although not required), you might want to add: Signed-off-by: Nicholas Bishop The patch itself is good. Thanks! Reviewed-by: Eric Engestrom > --- > docs/devinfo.html | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/docs/devinfo.html b/docs/devinfo.html > index 489d263..e13837c 100644 > --- a/docs/devinfo.html > +++ b/docs/devinfo.html > @@ -252,10 +252,14 @@ check for regressions. > Mailing Patches > > > -Patches should be sent to the Mesa mailing list for review. > -When submitting a patch make sure to use git send-email rather than attaching > -patches to emails. Sending patches as attachments prevents people from being > -able to provide in-line review comments. > +Patches should be sent to the mesa-dev mailing list for review: > +https://lists.freedesktop.org/mailman/listinfo/mesa-dev;> > +mesa-dev@lists.freedesktop.org. > +When submitting a patch make sure to use > +https://git-scm.com/docs/git-send-email;>git send-email > +rather than attaching patches to emails. Sending patches as > +attachments prevents people from being able to provide in-line review > +comments. > > > > -- > 2.7.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] docs: add links to clarify patch mailing section
From: Nicholas Bishop- Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify which list patches should be sent to - Added an explicit link to https://lists.freedesktop.org/mailman/listinfo/mesa-dev to show where to subscribe to the list - Added a link to https://git-scm.com/docs/git-send-email to help new users of that command --- docs/devinfo.html | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index 489d263..e13837c 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -252,10 +252,14 @@ check for regressions. Mailing Patches -Patches should be sent to the Mesa mailing list for review. -When submitting a patch make sure to use git send-email rather than attaching -patches to emails. Sending patches as attachments prevents people from being -able to provide in-line review comments. +Patches should be sent to the mesa-dev mailing list for review: +https://lists.freedesktop.org/mailman/listinfo/mesa-dev;> +mesa-dev@lists.freedesktop.org. +When submitting a patch make sure to use +https://git-scm.com/docs/git-send-email;>git send-email +rather than attaching patches to emails. Sending patches as +attachments prevents people from being able to provide in-line review +comments. -- 2.7.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev