Re: [Mesa-dev] [PATCH] editorconfig: Add max_line_length property

2019-01-08 Thread Eric Engestrom
On Monday, 2019-01-07 12:43:54 -0800, Dylan Baker wrote:
> Quoting Andres Gomez (2019-01-07 05:49:00)
> > The property is supported by the most of the editors, but not all:
> > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
> > 
> > Cc: Eric Engestrom 
> > Cc: Eric Anholt 
> > Signed-off-by: Andres Gomez 
> > ---
> >  .editorconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.editorconfig b/.editorconfig
> > index 06848f68c08..c2b772da6c1 100644
> > --- a/.editorconfig
> > +++ b/.editorconfig
> > @@ -11,6 +11,7 @@ tab_width = 8
> >  [*.{c,h,cpp,hpp,cc,hh}]
> >  indent_style = space
> >  indent_size = 3
> > +max_line_length = 78
> >  
> >  [{Makefile*,*.mk}]
> >  indent_style = tab
> > -- 
> > 2.18.0
> > 
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> I think the big ones are covered here: vim, emacs, atom, intellij (and
> deriviatives), resharper, rider. That seems like it covers pretty much 
> everyone.

Thanks, and agreed with Dylan; you can also have my:
Reviewed-by: Eric Engestrom 

> 
> Reviewed-by: Dylan Baker 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] editorconfig: Add max_line_length property

2019-01-07 Thread Dylan Baker
Quoting Andres Gomez (2019-01-07 05:49:00)
> The property is supported by the most of the editors, but not all:
> https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
> 
> Cc: Eric Engestrom 
> Cc: Eric Anholt 
> Signed-off-by: Andres Gomez 
> ---
>  .editorconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.editorconfig b/.editorconfig
> index 06848f68c08..c2b772da6c1 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -11,6 +11,7 @@ tab_width = 8
>  [*.{c,h,cpp,hpp,cc,hh}]
>  indent_style = space
>  indent_size = 3
> +max_line_length = 78
>  
>  [{Makefile*,*.mk}]
>  indent_style = tab
> -- 
> 2.18.0
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

I think the big ones are covered here: vim, emacs, atom, intellij (and
deriviatives), resharper, rider. That seems like it covers pretty much everyone.

Reviewed-by: Dylan Baker 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] editorconfig: Add max_line_length property

2019-01-07 Thread Andres Gomez
The property is supported by the most of the editors, but not all:
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length

Cc: Eric Engestrom 
Cc: Eric Anholt 
Signed-off-by: Andres Gomez 
---
 .editorconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.editorconfig b/.editorconfig
index 06848f68c08..c2b772da6c1 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -11,6 +11,7 @@ tab_width = 8
 [*.{c,h,cpp,hpp,cc,hh}]
 indent_style = space
 indent_size = 3
+max_line_length = 78
 
 [{Makefile*,*.mk}]
 indent_style = tab
-- 
2.18.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev