Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-28 Thread Emil Velikov 
On Wed, 28 Nov 2018 at 12:33, Eric Engestrom  wrote:
>
> On Tuesday, 2018-11-27 22:52:47 -0800, Matt Turner wrote:
> > Reviewed-by: Matt Turner 
> >
> > I'll commit it tomorrow.
>
> When you do that, the commit title should be fixed to something like
>   egl: add missing #include  in egldevice.h
> since the original commit title doesn't apply anymore.
>
> And while at it:
> Reviewed-by: Eric Engestrom 
> Cc: mesa-sta...@lists.freedesktop.org

With the above, patch is
Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-28 Thread Eric Engestrom 
On Tuesday, 2018-11-27 22:52:47 -0800, Matt Turner wrote:
> Reviewed-by: Matt Turner 
> 
> I'll commit it tomorrow.

When you do that, the commit title should be fixed to something like
  egl: add missing #include  in egldevice.h
since the original commit title doesn't apply anymore.

And while at it:
Reviewed-by: Eric Engestrom 
Cc: mesa-sta...@lists.freedesktop.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Matt Turner 
Reviewed-by: Matt Turner 

I'll commit it tomorrow.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Gurchetan Singh 
Otherwise, I get this error:

main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
   dev = NULL;
 ^~~~
with this config:

./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' 
--disable-glx
 --with-dri-drivers="i965" --with-gallium-drivers="" --enable-gbm

v3: Use stddef.h (Matt)
---
 src/egl/main/egldevice.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/egl/main/egldevice.h b/src/egl/main/egldevice.h
index ddcdcd17f5..83a47d5eac 100644
--- a/src/egl/main/egldevice.h
+++ b/src/egl/main/egldevice.h
@@ -31,9 +31,9 @@
 
 
 #include 
+#include 
 #include "egltypedefs.h"
 
-
 #ifdef __cplusplus
 extern "C" {
 #endif
-- 
2.18.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Matt Turner 
Wouldn't it be better to just include the stdlib.h/stddef.h header
that defines NULL?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Gurchetan Singh 
Otherwise, I get this error:

main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
   dev = NULL;
 ^~~~
with this config:

./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' 
--disable-glx
 --with-dri-drivers="i965" --with-gallium-drivers="" --enable-gbm

v2: remove change id
---
 src/egl/main/egldevice.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/egl/main/egldevice.h b/src/egl/main/egldevice.h
index ddcdcd17f5..f161942d26 100644
--- a/src/egl/main/egldevice.h
+++ b/src/egl/main/egldevice.h
@@ -33,6 +33,9 @@
 #include 
 #include "egltypedefs.h"
 
+#ifndef NULL
+#define NULL 0
+#endif
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.18.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Gurchetan Singh 
Otherwise, I get this error:

main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
   dev = NULL;
 ^~~~
with this config:

./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' 
--disable-glx
 --with-dri-drivers="i965" --with-gallium-drivers="" --enable-gbm

Change-Id: I4332bfcfd19aecf239497591507aad921fffedf1
---
 src/egl/main/egldevice.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/egl/main/egldevice.h b/src/egl/main/egldevice.h
index ddcdcd17f5a..f161942d26f 100644
--- a/src/egl/main/egldevice.h
+++ b/src/egl/main/egldevice.h
@@ -33,6 +33,9 @@
 #include 
 #include "egltypedefs.h"
 
+#ifndef NULL
+#define NULL 0
+#endif
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.18.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev