[Mesa-dev] [PATCH] egl_dri2: cleanup memory leak in dri2_create_context()

2014-05-08 Thread Emil Velikov
Cc: Kristian Høgsberg k...@bitplanet.net
Cc: Chad Versace chad.vers...@linux.intel.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
 src/egl/drivers/dri2/egl_dri2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 380bd7b..a5f71ed 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -811,8 +811,9 @@ dri2_create_context(_EGLDriver *drv, _EGLDisplay *disp, 
_EGLConfig *conf,
  api = __DRI_API_GLES3;
  break;
   default:
-_eglError(EGL_BAD_PARAMETER, eglCreateContext);
-return NULL;
+ _eglError(EGL_BAD_PARAMETER, eglCreateContext);
+ free(dri2_ctx);
+ return NULL;
   }
   break;
case EGL_OPENGL_API:
-- 
1.9.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] egl_dri2: cleanup memory leak in dri2_create_context()

2014-05-08 Thread Kristian Høgsberg
On Thu, May 8, 2014 at 8:49 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
 Cc: Kristian Høgsberg k...@bitplanet.net
 Cc: Chad Versace chad.vers...@linux.intel.com
 Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
 ---
  src/egl/drivers/dri2/egl_dri2.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Kristian Høgsberg k...@bitplanet.net

 diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
 index 380bd7b..a5f71ed 100644
 --- a/src/egl/drivers/dri2/egl_dri2.c
 +++ b/src/egl/drivers/dri2/egl_dri2.c
 @@ -811,8 +811,9 @@ dri2_create_context(_EGLDriver *drv, _EGLDisplay *disp, 
 _EGLConfig *conf,
   api = __DRI_API_GLES3;
   break;
default:
 -_eglError(EGL_BAD_PARAMETER, eglCreateContext);
 -return NULL;
 + _eglError(EGL_BAD_PARAMETER, eglCreateContext);
 + free(dri2_ctx);
 + return NULL;
}
break;
 case EGL_OPENGL_API:
 --
 1.9.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] egl_dri2: cleanup memory leak in dri2_create_context()

2014-05-08 Thread Chad Versace
On Thu, May 08, 2014 at 11:06:01AM -0700, Kristian Høgsberg wrote:
 On Thu, May 8, 2014 at 8:49 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
  Cc: Kristian Høgsberg k...@bitplanet.net
  Cc: Chad Versace chad.vers...@linux.intel.com
  Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
  ---
   src/egl/drivers/dri2/egl_dri2.c | 5 +++--
   1 file changed, 3 insertions(+), 2 deletions(-)
 
 Reviewed-by: Kristian Høgsberg k...@bitplanet.net

Reviewed-by: Chad Versace chad.vers...@linux.intel.com 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev