Re: [Mesa-dev] [PATCH] gallium/tgsi: use _mesa_roundevenf in micro_rnd

[Brian Paul]

Will do.

-Brian

On 05/26/2016 06:51 AM, Lars Hamre wrote:

Gentle ping for a gallium developer.
If nobody has any issues I would appreciate a push.

Regards,
Lars Hamre

On Thu, May 19, 2016 at 6:16 PM, Matt Turner  wrote:

On Thu, May 19, 2016 at 2:34 PM, Lars Hamre  wrote:

Fixes the following piglit tests (for softpipe):

/spec/glsl-1.30/execution/built-in-functions/...
fs-roundeven-float
fs-roundeven-vec2
fs-roundeven-vec3
fs-roundeven-vec4
vs-roundeven-float
vs-roundeven-vec2
vs-roundeven-vec3
vs-roundeven-vec4

/spec/glsl-1.50/execution/built-in-functions/...
gs-roundeven-float
gs-roundeven-vec2
gs-roundeven-vec3
gs-roundeven-vec4

Signed-off-by: Lars Hamre 

---

Note: someone with access will need to commit this
   after the review process.


I'm not going to commit it myself because I don't work on a Gallium
driver, but I'm very glad to see the patch.

Reviewed-by: Matt Turner 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/tgsi: use _mesa_roundevenf in micro_rnd

[Lars Hamre]

Gentle ping for a gallium developer.
If nobody has any issues I would appreciate a push.

Regards,
Lars Hamre

On Thu, May 19, 2016 at 6:16 PM, Matt Turner  wrote:
> On Thu, May 19, 2016 at 2:34 PM, Lars Hamre  wrote:
>> Fixes the following piglit tests (for softpipe):
>>
>> /spec/glsl-1.30/execution/built-in-functions/...
>> fs-roundeven-float
>> fs-roundeven-vec2
>> fs-roundeven-vec3
>> fs-roundeven-vec4
>> vs-roundeven-float
>> vs-roundeven-vec2
>> vs-roundeven-vec3
>> vs-roundeven-vec4
>>
>> /spec/glsl-1.50/execution/built-in-functions/...
>> gs-roundeven-float
>> gs-roundeven-vec2
>> gs-roundeven-vec3
>> gs-roundeven-vec4
>>
>> Signed-off-by: Lars Hamre 
>>
>> ---
>>
>> Note: someone with access will need to commit this
>>   after the review process.
>
> I'm not going to commit it myself because I don't work on a Gallium
> driver, but I'm very glad to see the patch.
>
> Reviewed-by: Matt Turner 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/tgsi: use _mesa_roundevenf in micro_rnd

[Matt Turner]

On Thu, May 19, 2016 at 2:34 PM, Lars Hamre  wrote:
> Fixes the following piglit tests (for softpipe):
>
> /spec/glsl-1.30/execution/built-in-functions/...
> fs-roundeven-float
> fs-roundeven-vec2
> fs-roundeven-vec3
> fs-roundeven-vec4
> vs-roundeven-float
> vs-roundeven-vec2
> vs-roundeven-vec3
> vs-roundeven-vec4
>
> /spec/glsl-1.50/execution/built-in-functions/...
> gs-roundeven-float
> gs-roundeven-vec2
> gs-roundeven-vec3
> gs-roundeven-vec4
>
> Signed-off-by: Lars Hamre 
>
> ---
>
> Note: someone with access will need to commit this
>   after the review process.

I'm not going to commit it myself because I don't work on a Gallium
driver, but I'm very glad to see the patch.

Reviewed-by: Matt Turner 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium/tgsi: use _mesa_roundevenf in micro_rnd

[Lars Hamre]

Fixes the following piglit tests (for softpipe):

/spec/glsl-1.30/execution/built-in-functions/...
fs-roundeven-float
fs-roundeven-vec2
fs-roundeven-vec3
fs-roundeven-vec4
vs-roundeven-float
vs-roundeven-vec2
vs-roundeven-vec3
vs-roundeven-vec4

/spec/glsl-1.50/execution/built-in-functions/...
gs-roundeven-float
gs-roundeven-vec2
gs-roundeven-vec3
gs-roundeven-vec4

Signed-off-by: Lars Hamre 

---

Note: someone with access will need to commit this
  after the review process.

 src/gallium/auxiliary/tgsi/tgsi_exec.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c 
b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index d483429..baf4a89 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
@@ -61,6 +61,7 @@
 #include "util/u_half.h"
 #include "util/u_memory.h"
 #include "util/u_math.h"
+#include "util/rounding.h"


 #define DEBUG_EXECUTION 0
@@ -543,10 +544,10 @@ static void
 micro_rnd(union tgsi_exec_channel *dst,
   const union tgsi_exec_channel *src)
 {
-   dst->f[0] = floorf(src->f[0] + 0.5f);
-   dst->f[1] = floorf(src->f[1] + 0.5f);
-   dst->f[2] = floorf(src->f[2] + 0.5f);
-   dst->f[3] = floorf(src->f[3] + 0.5f);
+   dst->f[0] = _mesa_roundevenf(src->f[0]);
+   dst->f[1] = _mesa_roundevenf(src->f[1]);
+   dst->f[2] = _mesa_roundevenf(src->f[2]);
+   dst->f[3] = _mesa_roundevenf(src->f[3]);
 }

 static void
--
2.5.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev