[Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.
Fix clang mismatched-tags warnings introduced with commit 4f5445a45d3ed02e00a061b10c943c0b079c6020. ./glsl_symbol_table.h:37:1: warning: class 'glsl_type' was previously declared as a struct [-Wmismatched-tags] class glsl_type; ^ ./glsl_types.h:86:8: note: previous use is here struct glsl_type { ^ ./glsl_symbol_table.h:37:1: note: did you mean struct here? class glsl_type; ^ Signed-off-by: Vinson Lee v...@freedesktop.org --- src/glsl/glsl_symbol_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_symbol_table.h b/src/glsl/glsl_symbol_table.h index 39b84e4..2528264 100644 --- a/src/glsl/glsl_symbol_table.h +++ b/src/glsl/glsl_symbol_table.h @@ -34,7 +34,7 @@ extern C { #include ir.h class symbol_table_entry; -class glsl_type; +struct glsl_type; /** * Facade class for _mesa_symbol_table -- 1.9.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.
I just wrote the same patch tonight. :) Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.
Ooops. My bad. Thanks for fixing this. LGTM Reading up on this warning it seems name mangling is pretty messed up with MSVC. I'll get a MSVC build system set up to make sure my future work extraneous includes does not introduce issues with MSVC. 2014-06-15 9:38 GMT+02:00 Matt Turner matts...@gmail.com: I just wrote the same patch tonight. :) Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.
On Sun, Jun 15, 2014 at 3:58 AM, Thomas Helland thomashellan...@gmail.com wrote: Ooops. My bad. Thanks for fixing this. LGTM Reading up on this warning it seems name mangling is pretty messed up with MSVC. I'll get a MSVC build system set up to make sure my future work extraneous includes does not introduce issues with MSVC. I don't think you really need to bother. It didn't break anything, and clang is also capable of warning about this. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev