Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Timothy Arceri 

On 8/1/19 2:51 am, Andres Gomez wrote:

On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote:

On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote:

Correct a typo introduced by
037f68d81e1 ("glsl: apply align layout qualifier rules to block
offsets")

Cc: Timothy Arceri 
Signed-off-by: Andres Gomez 


This should probably have this tag:

Fixes: 037f68d81e1 "glsl: apply align layout qualifier rules to block
 offsets"


Didn't think it was important enough to add the tag which will pull
into the stable releases ...

... it will also be more traceable with it added so, I suppose I will
do so.


Seems fine to go into stable :)

Reviewed-by: Timothy Arceri 

Thanks!




With that added:

Reviewed-by: Erik Faye-Lund 


Thanks! ☺


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Andres Gomez 
On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote:
> On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote:
> > Correct a typo introduced by
> > 037f68d81e1 ("glsl: apply align layout qualifier rules to block
> > offsets")
> > 
> > Cc: Timothy Arceri 
> > Signed-off-by: Andres Gomez 
> 
> This should probably have this tag:
> 
> Fixes: 037f68d81e1 "glsl: apply align layout qualifier rules to block
> offsets"

Didn't think it was important enough to add the tag which will pull
into the stable releases ... 

... it will also be more traceable with it added so, I suppose I will
do so.

> With that added:
> 
> Reviewed-by: Erik Faye-Lund 

Thanks! ☺

-- 
Br,

Andres

signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Erik Faye-Lund 
On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote:
> Correct a typo introduced by
> 037f68d81e1 ("glsl: apply align layout qualifier rules to block
> offsets")
> 
> Cc: Timothy Arceri 
> Signed-off-by: Andres Gomez 

This should probably have this tag:

Fixes: 037f68d81e1 "glsl: apply align layout qualifier rules to block
offsets"

With that added:

Reviewed-by: Erik Faye-Lund 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Andres Gomez 
Correct a typo introduced by
037f68d81e1 ("glsl: apply align layout qualifier rules to block offsets")

Cc: Timothy Arceri 
Signed-off-by: Andres Gomez 
---
 src/compiler/glsl/ast_to_hir.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 9199230a7af..8fdc1890ab0 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -7417,7 +7417,7 @@ ast_process_struct_or_iface_block_members(exec_list 
*instructions,
   if (member_align == 0 ||
   member_align & (member_align - 1)) {
  _mesa_glsl_error(, state, "align layout qualifier "
-  "in not a power of 2");
+  "is not a power of 2");
   } else {
  fields[i].offset = glsl_align(offset, member_align);
  next_offset = glsl_align(fields[i].offset + size, align);
-- 
2.18.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev