[Mesa-dev] [PATCH] glsl: fix packing support for arrays of doubles

2015-04-27 Thread Timothy Arceri
Broke in commit f00c5f85b82efe9535b18dbf97c4591fb28aeae6 when
adding support for multidimensional arrays
---
 src/glsl/lower_packed_varyings.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/glsl/lower_packed_varyings.cpp 
b/src/glsl/lower_packed_varyings.cpp
index f8e79bd..d8bebb5 100644
--- a/src/glsl/lower_packed_varyings.cpp
+++ b/src/glsl/lower_packed_varyings.cpp
@@ -645,8 +645,8 @@ lower_packed_varyings_visitor::needs_lowering(ir_variable 
*var)
if (var-data.explicit_location)
   return false;
 
-   if (var-type-without_array()-vector_elements == 4 
-   !var-type-is_double())
+   const glsl_type *type = var-type-without_array();
+   if (type-vector_elements == 4  !type-is_double())
   return false;
return true;
 }
-- 
2.1.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] glsl: fix packing support for arrays of doubles

2015-04-27 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu

(for the little that's worth... I didn't spot this in the original
commit. Oh well.)

On Mon, Apr 27, 2015 at 5:35 PM, Timothy Arceri t_arc...@yahoo.com.au wrote:
 Broke in commit f00c5f85b82efe9535b18dbf97c4591fb28aeae6 when
 adding support for multidimensional arrays
 ---
  src/glsl/lower_packed_varyings.cpp | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/src/glsl/lower_packed_varyings.cpp 
 b/src/glsl/lower_packed_varyings.cpp
 index f8e79bd..d8bebb5 100644
 --- a/src/glsl/lower_packed_varyings.cpp
 +++ b/src/glsl/lower_packed_varyings.cpp
 @@ -645,8 +645,8 @@ lower_packed_varyings_visitor::needs_lowering(ir_variable 
 *var)
 if (var-data.explicit_location)
return false;

 -   if (var-type-without_array()-vector_elements == 4 
 -   !var-type-is_double())
 +   const glsl_type *type = var-type-without_array();
 +   if (type-vector_elements == 4  !type-is_double())
return false;
 return true;
  }
 --
 2.1.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev