Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
On 08/25/2010 01:08 AM, Aras Pranckevicius wrote: The strtoll() #define should be put in the imports.h file. Perhaps you can update your patch for today's git code. Updated patch attached. Committed. Thanks. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
> The strtoll() #define should be put in the imports.h file. > Perhaps you can update your patch for today's git code. Updated patch attached. -- Aras Pranckevičius work: http://unity3d.com home: http://aras-p.info glsl-mesa-fixes-for-MSVC.patch Description: Binary data ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
On 08/24/2010 01:41 AM, Aras Pranckevicius wrote: > Could be; I'm not actually building full Mesa (just the GLSL compiler). At > least for snprintf, in MSVC it's _snprintf; no idea about others right now. Hmm, they are used by the new GLSL compiler (src/glsl/). Indeed, they are used by preprocessor (which I was not building before). Attached patch adds isspace(), strtoll() for MSVC, and fixes class vs struct mixage (MSVC really does not like "class" keyword when compiling C code). Your patch doesn't seem to be up to date with the latest code from git. The strtoll() #define should be put in the imports.h file. Perhaps you can update your patch for today's git code. I'll commit the isblank() function to imports.h though. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
> > > Could be; I'm not actually building full Mesa (just the GLSL compiler). > At > > least for snprintf, in MSVC it's _snprintf; no idea about others right > now. > Hmm, they are used by the new GLSL compiler (src/glsl/). Indeed, they are used by preprocessor (which I was not building before). Attached patch adds isspace(), strtoll() for MSVC, and fixes class vs struct mixage (MSVC really does not like "class" keyword when compiling C code). -- Aras Pranckevičius work: http://unity3d.com home: http://aras-p.info glsl-more-preprocessor-build-fixes-for-msvc.patch Description: Binary data ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
On Mon, Aug 23, 2010 at 2:57 PM, Aras Pranckevicius wrote: >> Not that familiar with MSVC, but when I built Mesa on Windows the other >> day, >> other than the defines introduced by this patch, these functions were also >> missing: snprintf, strtoll, and isblank. Is it me or the patch that >> misses >> something? > Could be; I'm not actually building full Mesa (just the GLSL compiler). At > least for snprintf, in MSVC it's _snprintf; no idea about others right now. Hmm, they are used by the new GLSL compiler (src/glsl/). -- o...@lunarg.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
> > Not that familiar with MSVC, but when I built Mesa on Windows the other > day, > other than the defines introduced by this patch, these functions were also > missing: snprintf, strtoll, and isblank. Is it me or the patch that misses > something? > Could be; I'm not actually building full Mesa (just the GLSL compiler). At least for snprintf, in MSVC it's _snprintf; no idea about others right now. -- Aras Pranckevičius work: http://unity3d.com home: http://aras-p.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
On Mon, Aug 23, 2010 at 2:25 PM, Aras Pranckevicius wrote: > Hi, > Attached patch fixes MSVC (2008) build. MSVC was still missing truncf, > exp2f, log2f (all used in GLSL2). > MSVC does not have trunc(), so defining truncf() to trunc() does not quite > work. The _XOPEN_SOURCE usage looked pretty weird as well; it made whole > that block not be included if the define is not there at all. Not that familiar with MSVC, but when I built Mesa on Windows the other day, other than the defines introduced by this patch, these functions were also missing: snprintf, strtoll, and isblank. Is it me or the patch that misses something? -- o...@lunarg.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] glsl / imports.h: fix MSVC build
Hi, Attached patch fixes MSVC (2008) build. MSVC was still missing truncf, exp2f, log2f (all used in GLSL2). MSVC does not have trunc(), so defining truncf() to trunc() does not quite work. The _XOPEN_SOURCE usage looked pretty weird as well; it made whole that block not be included if the define is not there at all. -- Aras Pranckevičius work: http://unity3d.com home: http://aras-p.info glsl-fix-msvc-build.patch Description: Binary data ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
