Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

[Marek Olšák]

Reviewed-by: Marek Olšák 

Marek

On Thu, Jun 8, 2017 at 9:21 AM, Vinson Lee  wrote:
> Fix build error.
>
>   CC   i915_surface.lo
> i915_surface.c:108:63: error: too few arguments to function call, expected 4, 
> have 3
>util_blitter_default_src_texture(_templ, src, src_level);
>   ^
> ../../../../src/gallium/auxiliary/util/u_blitter.h:271:1: note: 
> 'util_blitter_default_src_texture' declared here
> void util_blitter_default_src_texture(struct blitter_context *blitter,
> ^
>
> Fixes: a893c9169733 ("gallium/u_blitter: use 2D_ARRAY for cubemap blits if 
> possible")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101340
> Signed-off-by: Vinson Lee 
> ---
>  src/gallium/drivers/i915/i915_surface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/i915/i915_surface.c 
> b/src/gallium/drivers/i915/i915_surface.c
> index 27b0d9eae857..57e90c6ed23a 100644
> --- a/src/gallium/drivers/i915/i915_surface.c
> +++ b/src/gallium/drivers/i915/i915_surface.c
> @@ -105,7 +105,7 @@ i915_surface_copy_render(struct pipe_context *pipe,
>goto fallback;
>
> util_blitter_default_dst_texture(_templ, dst, dst_level, dstz);
> -   util_blitter_default_src_texture(_templ, src, src_level);
> +   util_blitter_default_src_texture(i915->blitter, _templ, src, 
> src_level);
>
> if (!util_blitter_is_copy_supported(i915->blitter, dst, src))
>goto fallback;
> --
> 2.13.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

[Juan A. Suarez Romero]

Reviewed-by: Juan A. Suarez Romero 


On Thu, 2017-06-08 at 07:21 +, Vinson Lee wrote:
> Fix build error.
> 
>   CC   i915_surface.lo
> i915_surface.c:108:63: error: too few arguments to function call, expected 4, 
> have 3
>util_blitter_default_src_texture(_templ, src, src_level);
>   ^
> ../../../../src/gallium/auxiliary/util/u_blitter.h:271:1: note: 
> 'util_blitter_default_src_texture' declared here
> void util_blitter_default_src_texture(struct blitter_context *blitter,
> ^
> 
> Fixes: a893c9169733 ("gallium/u_blitter: use 2D_ARRAY for cubemap blits if 
> possible")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101340
> Signed-off-by: Vinson Lee 
> ---
>  src/gallium/drivers/i915/i915_surface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/i915/i915_surface.c 
> b/src/gallium/drivers/i915/i915_surface.c
> index 27b0d9eae857..57e90c6ed23a 100644
> --- a/src/gallium/drivers/i915/i915_surface.c
> +++ b/src/gallium/drivers/i915/i915_surface.c
> @@ -105,7 +105,7 @@ i915_surface_copy_render(struct pipe_context *pipe,
>goto fallback;
>  
> util_blitter_default_dst_texture(_templ, dst, dst_level, dstz);
> -   util_blitter_default_src_texture(_templ, src, src_level);
> +   util_blitter_default_src_texture(i915->blitter, _templ, src, 
> src_level);
>  
> if (!util_blitter_is_copy_supported(i915->blitter, dst, src))
>goto fallback;
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

[Nicolai Hähnle]

On 08.06.2017 09:21, Vinson Lee wrote:

Fix build error.

   CC   i915_surface.lo
i915_surface.c:108:63: error: too few arguments to function call, expected 4, 
have 3
util_blitter_default_src_texture(_templ, src, src_level);
   ^
../../../../src/gallium/auxiliary/util/u_blitter.h:271:1: note: 
'util_blitter_default_src_texture' declared here
void util_blitter_default_src_texture(struct blitter_context *blitter,
^

Fixes: a893c9169733 ("gallium/u_blitter: use 2D_ARRAY for cubemap blits if 
possible")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101340
Signed-off-by: Vinson Lee 


Makes sense.

Reviewed-by: Nicolai Hähnle 



---
  src/gallium/drivers/i915/i915_surface.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/i915/i915_surface.c 
b/src/gallium/drivers/i915/i915_surface.c
index 27b0d9eae857..57e90c6ed23a 100644
--- a/src/gallium/drivers/i915/i915_surface.c
+++ b/src/gallium/drivers/i915/i915_surface.c
@@ -105,7 +105,7 @@ i915_surface_copy_render(struct pipe_context *pipe,
goto fallback;
  
 util_blitter_default_dst_texture(_templ, dst, dst_level, dstz);

-   util_blitter_default_src_texture(_templ, src, src_level);
+   util_blitter_default_src_texture(i915->blitter, _templ, src, src_level);
  
 if (!util_blitter_is_copy_supported(i915->blitter, dst, src))

goto fallback;




--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i915g: Add blitter_context argument.

[Vinson Lee]

Fix build error.

  CC   i915_surface.lo
i915_surface.c:108:63: error: too few arguments to function call, expected 4, 
have 3
   util_blitter_default_src_texture(_templ, src, src_level);
      ^
../../../../src/gallium/auxiliary/util/u_blitter.h:271:1: note: 
'util_blitter_default_src_texture' declared here
void util_blitter_default_src_texture(struct blitter_context *blitter,
^

Fixes: a893c9169733 ("gallium/u_blitter: use 2D_ARRAY for cubemap blits if 
possible")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101340
Signed-off-by: Vinson Lee 
---
 src/gallium/drivers/i915/i915_surface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/i915/i915_surface.c 
b/src/gallium/drivers/i915/i915_surface.c
index 27b0d9eae857..57e90c6ed23a 100644
--- a/src/gallium/drivers/i915/i915_surface.c
+++ b/src/gallium/drivers/i915/i915_surface.c
@@ -105,7 +105,7 @@ i915_surface_copy_render(struct pipe_context *pipe,
   goto fallback;
 
util_blitter_default_dst_texture(_templ, dst, dst_level, dstz);
-   util_blitter_default_src_texture(_templ, src, src_level);
+   util_blitter_default_src_texture(i915->blitter, _templ, src, src_level);
 
if (!util_blitter_is_copy_supported(i915->blitter, dst, src))
   goto fallback;
-- 
2.13.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev