Re: [Mesa-dev] [PATCH] i965/miptree: Use enum instead of boolean.

2018-10-10 Thread Jason Ekstrand 
Oops... My bad.

Reviewed-by: Jason Ekstrand 

On Wed, Oct 10, 2018 at 12:42 PM Rafael Antognolli <
rafael.antogno...@intel.com> wrote:

> ISL_AUX_USAGE_NONE happens to be the same as "false", but let's do the
> right thing and use the enum.
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> index 708757c47b8..b0333655ad5 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> @@ -613,9 +613,10 @@ intel_miptree_access_raw(struct brw_context *brw,
>   uint32_t level, uint32_t layer,
>   bool write)
>  {
> -   intel_miptree_prepare_access(brw, mt, level, 1, layer, 1, false,
> false);
> +   intel_miptree_prepare_access(brw, mt, level, 1, layer, 1,
> +ISL_AUX_USAGE_NONE, false);
> if (write)
> -  intel_miptree_finish_write(brw, mt, level, layer, 1, false);
> +  intel_miptree_finish_write(brw, mt, level, layer, 1,
> ISL_AUX_USAGE_NONE);
>  }
>
>  enum isl_aux_usage
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/miptree: Use enum instead of boolean.

2018-10-10 Thread Caio Marcelo de Oliveira Filho 
On Wed, Oct 10, 2018 at 10:41:43AM -0700, Rafael Antognolli wrote:
> ISL_AUX_USAGE_NONE happens to be the same as "false", but let's do the
> right thing and use the enum.
> ---

Reviewed-by: Caio Marcelo de Oliveira Filho 

I think intel_miptree_finish_depth() in intel_mipmap_tree.c might need
a similar change.


Caio
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/miptree: Use enum instead of boolean.

2018-10-10 Thread Dylan Baker 
Reviewed-by: Dylan Baker 

Quoting Rafael Antognolli (2018-10-10 10:41:43)
> ISL_AUX_USAGE_NONE happens to be the same as "false", but let's do the
> right thing and use the enum.
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h 
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> index 708757c47b8..b0333655ad5 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> @@ -613,9 +613,10 @@ intel_miptree_access_raw(struct brw_context *brw,
>   uint32_t level, uint32_t layer,
>   bool write)
>  {
> -   intel_miptree_prepare_access(brw, mt, level, 1, layer, 1, false, false);
> +   intel_miptree_prepare_access(brw, mt, level, 1, layer, 1,
> +ISL_AUX_USAGE_NONE, false);
> if (write)
> -  intel_miptree_finish_write(brw, mt, level, layer, 1, false);
> +  intel_miptree_finish_write(brw, mt, level, layer, 1, 
> ISL_AUX_USAGE_NONE);
>  }
>  
>  enum isl_aux_usage
> -- 
> 2.17.1
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/miptree: Use enum instead of boolean.

2018-10-10 Thread Rafael Antognolli 
ISL_AUX_USAGE_NONE happens to be the same as "false", but let's do the
right thing and use the enum.
---
 src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h 
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
index 708757c47b8..b0333655ad5 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
@@ -613,9 +613,10 @@ intel_miptree_access_raw(struct brw_context *brw,
  uint32_t level, uint32_t layer,
  bool write)
 {
-   intel_miptree_prepare_access(brw, mt, level, 1, layer, 1, false, false);
+   intel_miptree_prepare_access(brw, mt, level, 1, layer, 1,
+ISL_AUX_USAGE_NONE, false);
if (write)
-  intel_miptree_finish_write(brw, mt, level, layer, 1, false);
+  intel_miptree_finish_write(brw, mt, level, layer, 1, ISL_AUX_USAGE_NONE);
 }
 
 enum isl_aux_usage
-- 
2.17.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev