Re: [Mesa-dev] [PATCH] i965: Don't print a fatal-looking message if intelCreateContext fails.

[Eric Anholt]

Kenneth Graunke kenn...@whitecape.org writes:

 With the old context creation mechanism, an application asked the GL to
 give it a context.  Failing to produce a context was a fatal error.

 Now, with GLX_ARB_create_context, the application can request a specific
 version.  If it's higher than the maximum version we support, context
 creation will fail.  But this is a normal error that applications
 recover from.

 In particular, the new glxinfo tries to create OpenGL 4.3, 4.2, 4.1,
 4.0, 3.3, and 3.2 contexts before finally succeeding at creating a 3.1
 context.  This led to it printing the following message 6 times:
 brwCreateContext: failed to init intel context

 There's no need to alarm users (and developers) with such a message.

Reviewed-by: Eric Anholt e...@anholt.net


pgpFiIGP1w0KP.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Don't print a fatal-looking message if intelCreateContext fails.

[Kenneth Graunke]

With the old context creation mechanism, an application asked the GL to
give it a context.  Failing to produce a context was a fatal error.

Now, with GLX_ARB_create_context, the application can request a specific
version.  If it's higher than the maximum version we support, context
creation will fail.  But this is a normal error that applications
recover from.

In particular, the new glxinfo tries to create OpenGL 4.3, 4.2, 4.1,
4.0, 3.3, and 3.2 contexts before finally succeeding at creating a 3.1
context.  This led to it printing the following message 6 times:
brwCreateContext: failed to init intel context

There's no need to alarm users (and developers) with such a message.

Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
 src/mesa/drivers/dri/i965/brw_context.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_context.c 
b/src/mesa/drivers/dri/i965/brw_context.c
index fdbe327..72378bc 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/mesa/drivers/dri/i965/brw_context.c
@@ -138,7 +138,6 @@ brwCreateContext(int api,
   mesaVis, driContextPriv,
  sharedContextPrivate, functions,
  error)) {
-  printf(%s: failed to init intel context\n, __FUNCTION__);
   ralloc_free(brw);
   return false;
}
-- 
1.8.1.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev