Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

[Vadim Shovkoplias]

No worries :)

2018-01-24 11:36 GMT+02:00 Pohjolainen, Topi :

> On Tue, Jan 16, 2018 at 03:58:03PM +0200, Vadim Shovkoplias wrote:
> > Tested-by: Vadym Shovkoplias 
>
> Just realized that I pushed without your Tested-by, I'm sorry about that!
>
> >
> > 2018-01-16 15:31 GMT+02:00 Topi Pohjolainen  >:
> >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
> > > CC: xinghua@intel.com
> > > Signed-off-by: Topi Pohjolainen 
> > > ---
> > >  src/mesa/drivers/dri/i965/brw_draw.c | 6 --
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
> > > b/src/mesa/drivers/dri/i965/brw_draw.c
> > > index 7e29dcfd4e8..626cd3fdb70 100644
> > > --- a/src/mesa/drivers/dri/i965/brw_draw.c
> > > +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> > > @@ -441,8 +441,10 @@ brw_predraw_resolve_inputs(struct brw_context
> *brw,
> > > bool rendering)
> > >  tex_obj = intel_texture_object(u->TexObj);
> > >
> > >  if (tex_obj && tex_obj->mt) {
> > > -   intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> > > -   "as a shader image");
> > > +   if (rendering) {
> > > +  intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0,
> ~0,
> > > +  "as a shader image");
> > > +   }
> > >
> > > intel_miptree_prepare_image(brw, tex_obj->mt);
> > >
> > > --
> > > 2.14.1
> > >
> > > ___
> > > mesa-dev mailing list
> > > mesa-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > >
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

[Pohjolainen, Topi]

On Tue, Jan 16, 2018 at 03:58:03PM +0200, Vadim Shovkoplias wrote:
> Tested-by: Vadym Shovkoplias 

Just realized that I pushed without your Tested-by, I'm sorry about that!

> 
> 2018-01-16 15:31 GMT+02:00 Topi Pohjolainen :
> 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
> > CC: xinghua@intel.com
> > Signed-off-by: Topi Pohjolainen 
> > ---
> >  src/mesa/drivers/dri/i965/brw_draw.c | 6 --
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
> > b/src/mesa/drivers/dri/i965/brw_draw.c
> > index 7e29dcfd4e8..626cd3fdb70 100644
> > --- a/src/mesa/drivers/dri/i965/brw_draw.c
> > +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> > @@ -441,8 +441,10 @@ brw_predraw_resolve_inputs(struct brw_context *brw,
> > bool rendering)
> >  tex_obj = intel_texture_object(u->TexObj);
> >
> >  if (tex_obj && tex_obj->mt) {
> > -   intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> > -   "as a shader image");
> > +   if (rendering) {
> > +  intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> > +  "as a shader image");
> > +   }
> >
> > intel_miptree_prepare_image(brw, tex_obj->mt);
> >
> > --
> > 2.14.1
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

[Kenneth Graunke]

On Tuesday, January 16, 2018 5:31:23 AM PST Topi Pohjolainen wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
> CC: xinghua@intel.com
> Signed-off-by: Topi Pohjolainen 
> ---
>  src/mesa/drivers/dri/i965/brw_draw.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c 
> b/src/mesa/drivers/dri/i965/brw_draw.c
> index 7e29dcfd4e8..626cd3fdb70 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> @@ -441,8 +441,10 @@ brw_predraw_resolve_inputs(struct brw_context *brw, bool 
> rendering)
>  tex_obj = intel_texture_object(u->TexObj);
>  
>  if (tex_obj && tex_obj->mt) {
> -   intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> -   "as a shader image");
> +   if (rendering) {
> +  intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> +  "as a shader image");
> +   }
>  
> intel_miptree_prepare_image(brw, tex_obj->mt);
>  
> 

Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

[Pohjolainen, Topi]

On Tue, Jan 16, 2018 at 03:58:03PM +0200, Vadim Shovkoplias wrote:
> Tested-by: Vadym Shovkoplias 

Thanks :)

> 
> 2018-01-16 15:31 GMT+02:00 Topi Pohjolainen :
> 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
> > CC: xinghua@intel.com
> > Signed-off-by: Topi Pohjolainen 
> > ---
> >  src/mesa/drivers/dri/i965/brw_draw.c | 6 --
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
> > b/src/mesa/drivers/dri/i965/brw_draw.c
> > index 7e29dcfd4e8..626cd3fdb70 100644
> > --- a/src/mesa/drivers/dri/i965/brw_draw.c
> > +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> > @@ -441,8 +441,10 @@ brw_predraw_resolve_inputs(struct brw_context *brw,
> > bool rendering)
> >  tex_obj = intel_texture_object(u->TexObj);
> >
> >  if (tex_obj && tex_obj->mt) {
> > -   intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> > -   "as a shader image");
> > +   if (rendering) {
> > +  intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> > +  "as a shader image");
> > +   }
> >
> > intel_miptree_prepare_image(brw, tex_obj->mt);
> >
> > --
> > 2.14.1
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

[Vadim Shovkoplias]

Tested-by: Vadym Shovkoplias 

2018-01-16 15:31 GMT+02:00 Topi Pohjolainen :

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
> CC: xinghua@intel.com
> Signed-off-by: Topi Pohjolainen 
> ---
>  src/mesa/drivers/dri/i965/brw_draw.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
> b/src/mesa/drivers/dri/i965/brw_draw.c
> index 7e29dcfd4e8..626cd3fdb70 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> @@ -441,8 +441,10 @@ brw_predraw_resolve_inputs(struct brw_context *brw,
> bool rendering)
>  tex_obj = intel_texture_object(u->TexObj);
>
>  if (tex_obj && tex_obj->mt) {
> -   intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> -   "as a shader image");
> +   if (rendering) {
> +  intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
> +  "as a shader image");
> +   }
>
> intel_miptree_prepare_image(brw, tex_obj->mt);
>
> --
> 2.14.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

[Topi Pohjolainen]

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
CC: xinghua@intel.com
Signed-off-by: Topi Pohjolainen 
---
 src/mesa/drivers/dri/i965/brw_draw.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c 
b/src/mesa/drivers/dri/i965/brw_draw.c
index 7e29dcfd4e8..626cd3fdb70 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -441,8 +441,10 @@ brw_predraw_resolve_inputs(struct brw_context *brw, bool 
rendering)
 tex_obj = intel_texture_object(u->TexObj);
 
 if (tex_obj && tex_obj->mt) {
-   intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
-   "as a shader image");
+   if (rendering) {
+  intel_disable_rb_aux_buffer(brw, tex_obj->mt, 0, ~0,
+  "as a shader image");
+   }
 
intel_miptree_prepare_image(brw, tex_obj->mt);
 
-- 
2.14.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev