Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.
On Saturday, August 01, 2015 05:43:26 PM Emil Velikov wrote: > On 6 July 2015 at 21:40, Kenneth Graunke wrote: > > On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote: > >> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke > >> wrote: > >> > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a > >> > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX > >> > information.) In other words, it's been missing since we moved to > >> > dynamic binding table slot assignments. > >> > >> Author: Eric Anholt > >> AuthorDate: Wed Oct 2 14:07:40 2013 -0700 > >> CommitDate: Tue Oct 15 10:18:42 2013 -0700 > >> > >> Dang. > >> > >> How did you find this? > > > > After reading Eero's latest performance analysis observations, I decided > > to try marking render targets uncached (MOCS = UC) when blending and > > logic ops (i.e. things that cause render target reads) are disabled. > > > > This necessitated adding _NEW_COLOR. Then I realized > > BRW_NEW_FS_PROG_DATA was just plain missing. > > > Seems like this patch has fallen between the cracks. Can anyone take a > look or let me know if it's no longer applicable. > > Thanks > Emil Chris and I informally NAK'd it on IRC, sorry. It turns out that render_target_start is always 0, so omitting the bit should be harmless. We thought about sending a patch to delete the field and hardcode 0 instead... signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.
On 6 July 2015 at 21:40, Kenneth Graunke wrote: > On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote: >> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke >> wrote: >> > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a >> > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX >> > information.) In other words, it's been missing since we moved to >> > dynamic binding table slot assignments. >> >> Author: Eric Anholt >> AuthorDate: Wed Oct 2 14:07:40 2013 -0700 >> CommitDate: Tue Oct 15 10:18:42 2013 -0700 >> >> Dang. >> >> How did you find this? > > After reading Eero's latest performance analysis observations, I decided > to try marking render targets uncached (MOCS = UC) when blending and > logic ops (i.e. things that cause render target reads) are disabled. > > This necessitated adding _NEW_COLOR. Then I realized > BRW_NEW_FS_PROG_DATA was just plain missing. > Seems like this patch has fallen between the cracks. Can anyone take a look or let me know if it's no longer applicable. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.
On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote: > On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke wrote: > > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a > > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX > > information.) In other words, it's been missing since we moved to > > dynamic binding table slot assignments. > > Author: Eric Anholt > AuthorDate: Wed Oct 2 14:07:40 2013 -0700 > CommitDate: Tue Oct 15 10:18:42 2013 -0700 > > Dang. > > How did you find this? After reading Eero's latest performance analysis observations, I decided to try marking render targets uncached (MOCS = UC) when blending and logic ops (i.e. things that cause render target reads) are disabled. This necessitated adding _NEW_COLOR. Then I realized BRW_NEW_FS_PROG_DATA was just plain missing. signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.
On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke wrote: > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX > information.) In other words, it's been missing since we moved to > dynamic binding table slot assignments. Author: Eric Anholt AuthorDate: Wed Oct 2 14:07:40 2013 -0700 CommitDate: Tue Oct 15 10:18:42 2013 -0700 Dang. How did you find this? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.
It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a
(i965: Make a brw_stage_prog_data for storing the SURF_INDEX
information.) In other words, it's been missing since we moved to
dynamic binding table slot assignments.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
index 72aad96..b67d9ca 100644
--- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
+++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
@@ -770,7 +770,7 @@ update_renderbuffer_surfaces(struct brw_context *brw)
{
const struct gl_context *ctx = &brw->ctx;
- /* _NEW_BUFFERS | _NEW_COLOR */
+ /* _NEW_BUFFERS | _NEW_COLOR | BRW_NEW_FS_PROG_DATA */
const struct gl_framebuffer *fb = ctx->DrawBuffer;
brw_update_renderbuffer_surfaces(
brw, fb,
@@ -792,7 +792,8 @@ const struct brw_tracked_state brw_renderbuffer_surfaces = {
const struct brw_tracked_state gen6_renderbuffer_surfaces = {
.dirty = {
.mesa = _NEW_BUFFERS,
- .brw = BRW_NEW_BATCH,
+ .brw = BRW_NEW_BATCH |
+ BRW_NEW_FS_PROG_DATA,
},
.emit = update_renderbuffer_surfaces,
};
--
2.4.4
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
