Re: [Mesa-dev] [PATCH] i965: Initialize "separate" flag in VUE maps.

2016-12-06 Thread Matt Turner
Reviewed-by: Matt Turner 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] i965: Initialize "separate" flag in VUE maps.

2016-12-06 Thread Kenneth Graunke
This was uninitialized, which resulted in weird looking printouts where
it appeared that the TCS output and TES input patch URB entries differed
in SSO/non-SSO layout.  There is no "separable" layout for both, as
they're tied together.

It should have no other actual effect.

Signed-off-by: Kenneth Graunke 
---
 src/mesa/drivers/dri/i965/brw_vue_map.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_vue_map.c 
b/src/mesa/drivers/dri/i965/brw_vue_map.c
index 4d509d3..982a31f 100644
--- a/src/mesa/drivers/dri/i965/brw_vue_map.c
+++ b/src/mesa/drivers/dri/i965/brw_vue_map.c
@@ -205,6 +205,9 @@ brw_compute_tess_vue_map(struct brw_vue_map *vue_map,
/* I don't think anything actually uses this... */
vue_map->slots_valid = vertex_slots;
 
+   /* separate isn't really meaningful, but make sure it's initialized */
+   vue_map->separate = false;
+
vertex_slots &= ~(VARYING_BIT_TESS_LEVEL_OUTER |
  VARYING_BIT_TESS_LEVEL_INNER);
 
-- 
2.10.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev