[Mesa-dev] [PATCH] intel: Don't spam intelReadPixels: fallback to swrast all the time.

2013-05-15 Thread Kenneth Graunke
Unless the application is using PBOs, any call to glReadPixels will hit
this message.  Hitting this does mean mapping the buffer and accessing
it via the CPU, but that isn't necessarily the worst thing in the world.

apitrace's image dumping code hits this path, causing it to spam
hundreds of thousands of performance warnings via ARB_debug_output,
which makes it difficult to see actual errors.

Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
 src/mesa/drivers/dri/intel/intel_pixel_read.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_pixel_read.c 
b/src/mesa/drivers/dri/intel/intel_pixel_read.c
index 6b715d0..dd482af 100644
--- a/src/mesa/drivers/dri/intel/intel_pixel_read.c
+++ b/src/mesa/drivers/dri/intel/intel_pixel_read.c
@@ -188,8 +188,6 @@ intelReadPixels(struct gl_context * ctx,
intel_prepare_render(intel);
intel-front_buffer_dirty = dirty;
 
-   perf_debug(%s: fallback to swrast\n, __FUNCTION__);
-
/* Update Mesa state before calling _mesa_readpixels().
 * XXX this may not be needed since ReadPixels no longer uses the
 * span code.
-- 
1.8.2.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] intel: Don't spam intelReadPixels: fallback to swrast all the time.

2013-05-15 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes:

 Unless the application is using PBOs, any call to glReadPixels will hit
 this message.  Hitting this does mean mapping the buffer and accessing
 it via the CPU, but that isn't necessarily the worst thing in the world.

 apitrace's image dumping code hits this path, causing it to spam
 hundreds of thousands of performance warnings via ARB_debug_output,
 which makes it difficult to see actual errors.

Maybe only do so when dumping out of the PBO path?  It seems like this
is something useful to know about in that case.


pgpA16ElFYZ74.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev