Re: [Mesa-dev] [PATCH] mesa/st: fix infinite loops

2017-09-21 Thread Timothy Arceri 

On 21/09/17 16:55, Kenneth Graunke wrote:

On Wednesday, September 20, 2017 7:13:29 PM PDT Timothy Arceri wrote:

Fixes: 9ac8fece63a9 (glsl: Unify ir_constant::const_elements and ::components)
---
  src/mesa/program/ir_to_mesa.cpp| 2 +-
  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)


Looks good to me.

Reviewed-by: Kenneth Graunke 
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102910



Thanks. I already pushed with Dylan's rb since it was using up 16GB 
within seconds and making my machine unresponsive.

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/st: fix infinite loops

2017-09-21 Thread Kenneth Graunke 
On Wednesday, September 20, 2017 7:13:29 PM PDT Timothy Arceri wrote:
> Fixes: 9ac8fece63a9 (glsl: Unify ir_constant::const_elements and ::components)
> ---
>  src/mesa/program/ir_to_mesa.cpp| 2 +-
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Looks good to me.

Reviewed-by: Kenneth Graunke 
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102910

signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa/st: fix infinite loops

2017-09-20 Thread Timothy Arceri 
Fixes: 9ac8fece63a9 (glsl: Unify ir_constant::const_elements and ::components)
---
 src/mesa/program/ir_to_mesa.cpp| 2 +-
 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp
index 03d615ffe4..e4803aa490 100644
--- a/src/mesa/program/ir_to_mesa.cpp
+++ b/src/mesa/program/ir_to_mesa.cpp
@@ -1915,21 +1915,21 @@ ir_to_mesa_visitor::visit(ir_constant *ir)
 
   for (i = 0; i < ir->type->length; i++) {
  ir_constant *const field_value = ir->get_record_field(i);
 int size = type_size(field_value->type);
 
 assert(size > 0);
 
 field_value->accept(this);
 src = this->result;
 
-for (i = 0; i < (unsigned int)size; i++) {
+ for (unsigned j = 0; j < (unsigned int)size; j++) {
emit(ir, OPCODE_MOV, temp, src);
 
src.index++;
temp.index++;
 }
   }
   this->result = temp_base;
   return;
}
 
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp 
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index b49590bd6b..609920a7a8 100644
--- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
@@ -3047,21 +3047,21 @@ glsl_to_tgsi_visitor::visit(ir_constant *ir)
 
   for (i = 0; i < ir->type->length; i++) {
  ir_constant *const field_value = ir->get_record_field(i);
  int size = type_size(field_value->type);
 
  assert(size > 0);
 
  field_value->accept(this);
  src = this->result;
 
- for (i = 0; i < (unsigned int)size; i++) {
+ for (unsigned j = 0; j < (unsigned int)size; j++) {
 emit_asm(ir, TGSI_OPCODE_MOV, temp, src);
 
 src.index++;
 temp.index++;
  }
   }
   this->result = temp_base;
   return;
}
 
-- 
2.13.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev