Re: [Mesa-dev] [PATCH] mesa: lower severity for GLSL compiler warnings

[Timothy Arceri]

On 14/02/17 05:07, Matt Turner wrote:

Agreed. The GL_KHR_debug spec says MEDIUM means "Severe performance
warnings; GLSL or other shader compiler and linker warnings; use of
currently deprecated behavior", while HIGH means "Any GL error;
dangerous undefined behavior; any GLSL or ARB shader compiler and
linker errors;"

Reviewed-by: Matt Turner 

I'll give it a day or so before I commit it, so others have an
opportunity to comment.

Yeah make sense to me.

Reviewed-by: Timothy Arceri 


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: lower severity for GLSL compiler warnings

[Matt Turner]

Agreed. The GL_KHR_debug spec says MEDIUM means "Severe performance
warnings; GLSL or other shader compiler and linker warnings; use of
currently deprecated behavior", while HIGH means "Any GL error;
dangerous undefined behavior; any GLSL or ARB shader compiler and
linker errors;"

Reviewed-by: Matt Turner 

I'll give it a day or so before I commit it, so others have an
opportunity to comment.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: lower severity for GLSL compiler warnings

[James Legg]

This matches the examples in the GL_KHR_debug spec.
---
 src/mesa/main/errors.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c
index 3a40c74..ad495d6 100644
--- a/src/mesa/main/errors.c
+++ b/src/mesa/main/errors.c
@@ -385,7 +385,8 @@ _mesa_shader_debug(struct gl_context *ctx, GLenum type, 
GLuint *id,
const char *msg)
 {
enum mesa_debug_source source = MESA_DEBUG_SOURCE_SHADER_COMPILER;
-   enum mesa_debug_severity severity = MESA_DEBUG_SEVERITY_HIGH;
+   enum mesa_debug_severity severity = (type ==  MESA_DEBUG_TYPE_ERROR)
+   ? MESA_DEBUG_SEVERITY_HIGH : MESA_DEBUG_SEVERITY_MEDIUM;
int len;
 
_mesa_debug_get_id(id);
-- 
2.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev