Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

[Timothy Arceri]

On Fri, 2016-06-17 at 16:09 +0200, ⚛ wrote:
> Hello. Are you editing those files by hand?

Recently as I've come across tabs I do a quick check to see how many
are in the file, if its not many then I remove them.

I don't think there would be much interests in doing a batch conversion
as this would just make rebasing difficult. Also sometimes a tab
doesn't always match up to 8 spaces as you would expect.

> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

[Eric Engestrom]

On Fri, Jun 17, 2016 at 04:09:55PM +0200, ⚛ wrote:
> Hello. Are you editing those files by hand?

Yup, editing everything by hand. You just need a magnetized needle and
a steady hand. I'm still learning to use C-x M-c M-butterfly though,
haven't mastered that yet.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

[⚛]

Hello. Are you editing those files by hand?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

[Samuel Iglesias Gonsálvez]

Reviewed-by: Samuel Iglesias Gonsálvez 

On 17/06/16 07:12, Timothy Arceri wrote:
> ---
>  src/mesa/main/api_validate.c | 22 +++---
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
> index c7625c3..4ef86b8 100644
> --- a/src/mesa/main/api_validate.c
> +++ b/src/mesa/main/api_validate.c
> @@ -54,7 +54,7 @@ check_valid_to_render(struct gl_context *ctx, const char 
> *function)
>/* For OpenGL ES, only draw if we have vertex positions
> */
>if (!ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_POS].Enabled)
> -  return false;
> + return false;
>break;
>  
> case API_OPENGL_CORE:
> @@ -346,10 +346,10 @@ _mesa_valid_prim_mode(struct gl_context *ctx, GLenum 
> mode, const char *name)
>}
>if (!pass) {
>   _mesa_error(ctx, GL_INVALID_OPERATION,
> -  "%s(mode=%s vs transform feedback %s)",
> -  name,
> -  _mesa_lookup_prim_by_nr(mode),
> -  _mesa_lookup_prim_by_nr(ctx->TransformFeedback.Mode));
> + "%s(mode=%s vs transform feedback %s)",
> + name,
> + _mesa_lookup_prim_by_nr(mode),
> + 
> _mesa_lookup_prim_by_nr(ctx->TransformFeedback.Mode));
>   return GL_FALSE;
>}
> }
> @@ -431,8 +431,8 @@ validate_DrawElements_common(struct gl_context *ctx,
>   */
>  GLboolean
>  _mesa_validate_DrawElements(struct gl_context *ctx,
> - GLenum mode, GLsizei count, GLenum type,
> - const GLvoid *indices)
> +GLenum mode, GLsizei count, GLenum type,
> +const GLvoid *indices)
>  {
> FLUSH_CURRENT(ctx, 0);
>  
> @@ -494,9 +494,9 @@ _mesa_validate_MultiDrawElements(struct gl_context *ctx,
>   */
>  GLboolean
>  _mesa_validate_DrawRangeElements(struct gl_context *ctx, GLenum mode,
> -  GLuint start, GLuint end,
> -  GLsizei count, GLenum type,
> -  const GLvoid *indices)
> + GLuint start, GLuint end,
> + GLsizei count, GLenum type,
> + const GLvoid *indices)
>  {
> FLUSH_CURRENT(ctx, 0);
>  
> @@ -580,7 +580,7 @@ _mesa_validate_DrawArraysInstanced(struct gl_context 
> *ctx, GLenum mode, GLint fi
>  
> if (first < 0) {
>_mesa_error(ctx, GL_INVALID_VALUE,
> -   "glDrawArraysInstanced(start=%d)", first);
> +  "glDrawArraysInstanced(start=%d)", first);
>return GL_FALSE;
> }
>  
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

[Timothy Arceri]

---
 src/mesa/main/api_validate.c | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
index c7625c3..4ef86b8 100644
--- a/src/mesa/main/api_validate.c
+++ b/src/mesa/main/api_validate.c
@@ -54,7 +54,7 @@ check_valid_to_render(struct gl_context *ctx, const char 
*function)
   /* For OpenGL ES, only draw if we have vertex positions
*/
   if (!ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_POS].Enabled)
-return false;
+ return false;
   break;
 
case API_OPENGL_CORE:
@@ -346,10 +346,10 @@ _mesa_valid_prim_mode(struct gl_context *ctx, GLenum 
mode, const char *name)
   }
   if (!pass) {
  _mesa_error(ctx, GL_INVALID_OPERATION,
-"%s(mode=%s vs transform feedback %s)",
-name,
-_mesa_lookup_prim_by_nr(mode),
-_mesa_lookup_prim_by_nr(ctx->TransformFeedback.Mode));
+ "%s(mode=%s vs transform feedback %s)",
+ name,
+ _mesa_lookup_prim_by_nr(mode),
+ _mesa_lookup_prim_by_nr(ctx->TransformFeedback.Mode));
  return GL_FALSE;
   }
}
@@ -431,8 +431,8 @@ validate_DrawElements_common(struct gl_context *ctx,
  */
 GLboolean
 _mesa_validate_DrawElements(struct gl_context *ctx,
-   GLenum mode, GLsizei count, GLenum type,
-   const GLvoid *indices)
+GLenum mode, GLsizei count, GLenum type,
+const GLvoid *indices)
 {
FLUSH_CURRENT(ctx, 0);
 
@@ -494,9 +494,9 @@ _mesa_validate_MultiDrawElements(struct gl_context *ctx,
  */
 GLboolean
 _mesa_validate_DrawRangeElements(struct gl_context *ctx, GLenum mode,
-GLuint start, GLuint end,
-GLsizei count, GLenum type,
-const GLvoid *indices)
+ GLuint start, GLuint end,
+ GLsizei count, GLenum type,
+ const GLvoid *indices)
 {
FLUSH_CURRENT(ctx, 0);
 
@@ -580,7 +580,7 @@ _mesa_validate_DrawArraysInstanced(struct gl_context *ctx, 
GLenum mode, GLint fi
 
if (first < 0) {
   _mesa_error(ctx, GL_INVALID_VALUE,
- "glDrawArraysInstanced(start=%d)", first);
+  "glDrawArraysInstanced(start=%d)", first);
   return GL_FALSE;
}
 
-- 
2.5.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev