Re: [Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

[Józef Kucia]

On Mon, Nov 26, 2018 at 4:23 PM Lionel Landwerlin
 wrote:
>
> On 26/11/2018 15:04, Józef Kucia wrote:
> > Signed-off-by: Józef Kucia 
>
>
> Reviewed-by: Lionel Landwerlin 
>
>

Please push the patch for me. I don't have commit access.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

[Lionel Landwerlin]

On 26/11/2018 15:04, Józef Kucia wrote:

Signed-off-by: Józef Kucia 



Reviewed-by: Lionel Landwerlin 



---
  src/compiler/nir/nir_print.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c
index e20c28fec874..9ecb2a7c54e6 100644
--- a/src/compiler/nir/nir_print.c
+++ b/src/compiler/nir/nir_print.c
@@ -721,7 +721,7 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, 
print_state *state)
  [GLSL_SAMPLER_DIM_SUBPASS_MS] = "Subpass-MSAA",
   };
   enum glsl_sampler_dim dim = nir_intrinsic_image_dim(instr);
- assert(dim < ARRAY_SIZE(dim_name) && dim_name[idx]);
+ assert(dim < ARRAY_SIZE(dim_name) && dim_name[dim]);
   fprintf(fp, " image_dim=%s", dim_name[dim]);
} else if (idx == NIR_INTRINSIC_IMAGE_ARRAY) {
   bool array = nir_intrinsic_image_dim(instr);



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

[Józef Kucia]

Signed-off-by: Józef Kucia 
---
 src/compiler/nir/nir_print.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c
index e20c28fec874..9ecb2a7c54e6 100644
--- a/src/compiler/nir/nir_print.c
+++ b/src/compiler/nir/nir_print.c
@@ -721,7 +721,7 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, 
print_state *state)
 [GLSL_SAMPLER_DIM_SUBPASS_MS] = "Subpass-MSAA",
  };
  enum glsl_sampler_dim dim = nir_intrinsic_image_dim(instr);
- assert(dim < ARRAY_SIZE(dim_name) && dim_name[idx]);
+ assert(dim < ARRAY_SIZE(dim_name) && dim_name[dim]);
  fprintf(fp, " image_dim=%s", dim_name[dim]);
   } else if (idx == NIR_INTRINSIC_IMAGE_ARRAY) {
  bool array = nir_intrinsic_image_dim(instr);
-- 
2.18.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev