Re: [Mesa-dev] [PATCH] nvc0: fix wrong use of BLIT_SRC_Y_INT for 2D texture copy

2015-07-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu

I think this only gets called for copy_region, which in turn probably
can't be reached by MS surfaces. Not sure, but this is definitely
right anyways.

On Mon, Jul 6, 2015 at 4:06 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
 According to nv50, this should be src-ms_y instead of src-ms_x. This
 code is here since 2012, so it's probably a typo error which has never
 been detected since a long time. I didn't do a full piglit run to check
 if it fixes some other weird issues.

 Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
 ---
  src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c 
 b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
 index a820de7..53cd8cd 100644
 --- a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
 +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
 @@ -189,7 +189,7 @@ nvc0_2d_texture_do_copy(struct nouveau_pushbuf *push,
 PUSH_DATA (push, 0);
 PUSH_DATA (push, sx  src-ms_x);
 PUSH_DATA (push, 0);
 -   PUSH_DATA (push, sy  src-ms_x);
 +   PUSH_DATA (push, sy  src-ms_y);

 return 0;
  }
 --
 2.4.5

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] nvc0: fix wrong use of BLIT_SRC_Y_INT for 2D texture copy

2015-07-06 Thread Samuel Pitoiset
According to nv50, this should be src-ms_y instead of src-ms_x. This
code is here since 2012, so it's probably a typo error which has never
been detected since a long time. I didn't do a full piglit run to check
if it fixes some other weird issues.

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
 src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c 
b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
index a820de7..53cd8cd 100644
--- a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
+++ b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
@@ -189,7 +189,7 @@ nvc0_2d_texture_do_copy(struct nouveau_pushbuf *push,
PUSH_DATA (push, 0);
PUSH_DATA (push, sx  src-ms_x);
PUSH_DATA (push, 0);
-   PUSH_DATA (push, sy  src-ms_x);
+   PUSH_DATA (push, sy  src-ms_y);
 
return 0;
 }
-- 
2.4.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev