Re: [Mesa-dev] [PATCH] osmesa: don't check SmoothFlag twice

[Eric Engestrom]

On Sunday, 2018-01-14 23:59:48 +0200, Grazvydas Ignotas wrote:
> Trivial. Found by Coccinelle.

Series is:
Reviewed-by: Eric Engestrom 

> ---
>  src/mesa/drivers/osmesa/osmesa.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/osmesa/osmesa.c 
> b/src/mesa/drivers/osmesa/osmesa.c
> index 1df3da4..e0f87b8 100644
> --- a/src/mesa/drivers/osmesa/osmesa.c
> +++ b/src/mesa/drivers/osmesa/osmesa.c
> @@ -212,11 +212,10 @@ osmesa_choose_line_function( struct gl_context *ctx )
> */
>return NULL;
> }
>  
> if (ctx->RenderMode != GL_RENDER ||
> -   ctx->Line.SmoothFlag ||
> ctx->Texture._MaxEnabledTexImageUnit == -1 ||
> ctx->Light.ShadeModel != GL_FLAT ||
> ctx->Line.Width != 1.0F ||
> ctx->Line.StippleFlag ||
> ctx->Line.SmoothFlag) {
> -- 
> 2.7.4
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] osmesa: don't check SmoothFlag twice

[Grazvydas Ignotas]

Trivial. Found by Coccinelle.
---
 src/mesa/drivers/osmesa/osmesa.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c
index 1df3da4..e0f87b8 100644
--- a/src/mesa/drivers/osmesa/osmesa.c
+++ b/src/mesa/drivers/osmesa/osmesa.c
@@ -212,11 +212,10 @@ osmesa_choose_line_function( struct gl_context *ctx )
*/
   return NULL;
}
 
if (ctx->RenderMode != GL_RENDER ||
-   ctx->Line.SmoothFlag ||
ctx->Texture._MaxEnabledTexImageUnit == -1 ||
ctx->Light.ShadeModel != GL_FLAT ||
ctx->Line.Width != 1.0F ||
ctx->Line.StippleFlag ||
ctx->Line.SmoothFlag) {
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev