[Mesa-dev] [PATCH] panfrost/midgard: Don't assign var locations ourselves
This piece of code was cargo-culted from the ir3 standalone compiler and made sense when we were a standalone compiler ourselves. Unfortunately, for the online compiler, mesa/st *already handles this for us* and if we duplicate it here, we're duplicating it *incorrectly*. So just delete these lines and fix a heck of a lot of tests. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/ci/expected-failures.txt | 412 -- .../panfrost/midgard/midgard_compile.c| 6 - 2 files changed, 418 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt b/src/gallium/drivers/panfrost/ci/expected-failures.txt index 0ae11321ff4..6be9c83f4af 100644 --- a/src/gallium/drivers/panfrost/ci/expected-failures.txt +++ b/src/gallium/drivers/panfrost/ci/expected-failures.txt @@ -320,24 +320,6 @@ dEQP-GLES2.functional.polygon_offset.fixed16_render_with_units dEQP-GLES2.functional.polygon_offset.fixed16_result_depth_clamp dEQP-GLES2.functional.rasterization.limits.points dEQP-GLES2.functional.shaders.builtin_variable.fragcoord_w -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat2_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat2_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat3_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat3_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat4_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat4_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat2_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat2_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat3_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat3_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat4_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat4_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat2_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat2_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat3_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat3_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat4_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat4_vertex dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.bool_to_mat3_vertex dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.float_to_mat3_vertex dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.int_to_mat3_vertex @@ -345,19 +327,6 @@ dEQP-GLES2.functional.shaders.functions.control_flow.return_after_continue_verte dEQP-GLES2.functional.shaders.functions.control_flow.return_after_loop_sequence_vertex dEQP-GLES2.functional.shaders.functions.control_flow.return_in_loop_if_fragment dEQP-GLES2.functional.shaders.functions.control_flow.return_in_loop_if_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat2_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat2_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat3_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat3_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat4_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat4_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.mat2_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.mat2_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.mat3_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.mat3_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.mat4_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.mat4_vertex -dEQP-GLES2.functional.shaders.indexing.matrix_subscript.mat4_dynamic_loop_write_dynamic_loop_read_vertex dEQP-GLES2.functional.shaders.indexing.tmp_array.float_dynamic_loop_write_dynamic_loop_read_fragment dEQP-GLES2.functional.shaders.indexing.tmp_array.float_dynamic_loop_write_dynamic_loop_read_vertex dEQP-GLES2.functional.shaders.indexing.tmp_array.vec2_dynamic_loop_write_dynamic_loop_read_fragment @@ -382,387 +351,6 @@ dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscr dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscript_write_static_loop_subscript_read_vertex dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscript_write_static_subscript_read_fragment dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscript_write_static_subscript_read_vertex -dEQP-GLES2.functional.shaders.linkage.varying_type_mat2 -dEQP-GLES2.functional.shaders.linkage.varying_type_mat3 -dEQP-GLES2.functional.shaders.linkage.varying_type_mat4
[Mesa-dev] [PATCH] panfrost/midgard: Don't assign var locations ourselves
This piece of code was cargo-culted from the ir3 standalone compiler and made sense when we were a standalone compiler ourselves. Unfortunately, for the online compiler, mesa/st *already handles this for us* and if we duplicate it here, we're duplicating it *incorrectly*. So just delete these lines and fix a heck of a lot of tests. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/ci/expected-failures.txt | 412 -- .../panfrost/midgard/midgard_compile.c| 6 - 2 files changed, 418 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt b/src/gallium/drivers/panfrost/ci/expected-failures.txt index 0ae11321ff4..6be9c83f4af 100644 --- a/src/gallium/drivers/panfrost/ci/expected-failures.txt +++ b/src/gallium/drivers/panfrost/ci/expected-failures.txt @@ -320,24 +320,6 @@ dEQP-GLES2.functional.polygon_offset.fixed16_render_with_units dEQP-GLES2.functional.polygon_offset.fixed16_result_depth_clamp dEQP-GLES2.functional.rasterization.limits.points dEQP-GLES2.functional.shaders.builtin_variable.fragcoord_w -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat2_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat2_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat3_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat3_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat4_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat2_to_mat4_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat2_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat2_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat3_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat3_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat4_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat3_to_mat4_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat2_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat2_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat3_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat3_vertex -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat4_fragment -dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.mat4_to_mat4_vertex dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.bool_to_mat3_vertex dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.float_to_mat3_vertex dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.int_to_mat3_vertex @@ -345,19 +327,6 @@ dEQP-GLES2.functional.shaders.functions.control_flow.return_after_continue_verte dEQP-GLES2.functional.shaders.functions.control_flow.return_after_loop_sequence_vertex dEQP-GLES2.functional.shaders.functions.control_flow.return_in_loop_if_fragment dEQP-GLES2.functional.shaders.functions.control_flow.return_in_loop_if_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat2_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat2_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat3_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat3_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat4_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.float_mat4_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.mat2_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.mat2_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.mat3_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.mat3_vertex -dEQP-GLES2.functional.shaders.functions.datatypes.mat4_fragment -dEQP-GLES2.functional.shaders.functions.datatypes.mat4_vertex -dEQP-GLES2.functional.shaders.indexing.matrix_subscript.mat4_dynamic_loop_write_dynamic_loop_read_vertex dEQP-GLES2.functional.shaders.indexing.tmp_array.float_dynamic_loop_write_dynamic_loop_read_fragment dEQP-GLES2.functional.shaders.indexing.tmp_array.float_dynamic_loop_write_dynamic_loop_read_vertex dEQP-GLES2.functional.shaders.indexing.tmp_array.vec2_dynamic_loop_write_dynamic_loop_read_fragment @@ -382,387 +351,6 @@ dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscr dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscript_write_static_loop_subscript_read_vertex dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscript_write_static_subscript_read_fragment dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec4_dynamic_loop_subscript_write_static_subscript_read_vertex -dEQP-GLES2.functional.shaders.linkage.varying_type_mat2 -dEQP-GLES2.functional.shaders.linkage.varying_type_mat3 -dEQP-GLES2.functional.shaders.linkage.varying_type_mat4
