Re: [Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland
On 04/05/2018 01:18 PM, Bas Nieuwenhuizen wrote: On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset wrote: Ported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index dd3189c67d..44caf0eeae 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -72,6 +72,11 @@ radv_image_is_tc_compat_htile(struct radv_device *device, if (device->physical_device->rad_info.chip_class < VI) return false; + /* TC-compat HTILE seems buggy on Tonga/Iceland. */ Can we please get a reference on what seems buggy about it? This could very well something that is done incorrectly,s o I'd like something to check to see if that is fixed. It's a hardware bug apparently. If you have a Tonga or Iceland card, feel free to launch CTS with/without this patch. I can improve the comment as well. + if (device->physical_device->rad_info.family == CHIP_TONGA || + device->physical_device->rad_info.family == CHIP_ICELAND) + return false; + if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) return false; -- 2.16.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland
On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset wrote: > Ported from RadeonSI. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c > index dd3189c67d..44caf0eeae 100644 > --- a/src/amd/vulkan/radv_image.c > +++ b/src/amd/vulkan/radv_image.c > @@ -72,6 +72,11 @@ radv_image_is_tc_compat_htile(struct radv_device *device, > if (device->physical_device->rad_info.chip_class < VI) > return false; > > + /* TC-compat HTILE seems buggy on Tonga/Iceland. */ Can we please get a reference on what seems buggy about it? This could very well something that is done incorrectly,s o I'd like something to check to see if that is fixed. > + if (device->physical_device->rad_info.family == CHIP_TONGA || > + device->physical_device->rad_info.family == CHIP_ICELAND) > + return false; > + > if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) > return false; > > -- > 2.16.3 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland
Ported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index dd3189c67d..44caf0eeae 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -72,6 +72,11 @@ radv_image_is_tc_compat_htile(struct radv_device *device, if (device->physical_device->rad_info.chip_class < VI) return false; + /* TC-compat HTILE seems buggy on Tonga/Iceland. */ + if (device->physical_device->rad_info.family == CHIP_TONGA || + device->physical_device->rad_info.family == CHIP_ICELAND) + return false; + if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) return false; -- 2.16.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
