Re: [Mesa-dev] [PATCH] radv: don't set surf_index for stencil-only images

[Samuel Pitoiset]

Reviewed-by: Samuel Pitoiset 

On 12/14/18 7:32 PM, Rhys Perry wrote:

Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)')
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116
Signed-off-by: Rhys Perry 
---
Unfortunately I was not able to test this patch on a Polaris due to hardware
issues. It fixed the deqp-vk tests mentioned in the bugzilla without regressions
on Vega though.

  src/amd/vulkan/radv_image.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 2cff4d5283..2bd74e202f 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -986,7 +986,7 @@ radv_image_create(VkDevice _device,
  
  	image->shareable = vk_find_struct_const(pCreateInfo->pNext,


EXTERNAL_MEMORY_IMAGE_CREATE_INFO_KHR) != NULL;
-   if (!vk_format_is_depth(pCreateInfo->format) && !create_info->scanout && 
!image->shareable) {
+   if (!vk_format_is_depth_or_stencil(pCreateInfo->format) && !create_info->scanout 
&& !image->shareable) {
image->info.surf_index = >image_mrt_offset_counter;
}
  


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: don't set surf_index for stencil-only images

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen 
On Fri, Dec 14, 2018 at 7:32 PM Rhys Perry  wrote:
>
> Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)')
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116
> Signed-off-by: Rhys Perry 
> ---
> Unfortunately I was not able to test this patch on a Polaris due to hardware
> issues. It fixed the deqp-vk tests mentioned in the bugzilla without 
> regressions
> on Vega though.
>
>  src/amd/vulkan/radv_image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index 2cff4d5283..2bd74e202f 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -986,7 +986,7 @@ radv_image_create(VkDevice _device,
>
> image->shareable = vk_find_struct_const(pCreateInfo->pNext,
> 
> EXTERNAL_MEMORY_IMAGE_CREATE_INFO_KHR) != NULL;
> -   if (!vk_format_is_depth(pCreateInfo->format) && !create_info->scanout 
> && !image->shareable) {
> +   if (!vk_format_is_depth_or_stencil(pCreateInfo->format) && 
> !create_info->scanout && !image->shareable) {
> image->info.surf_index = >image_mrt_offset_counter;
> }
>
> --
> 2.19.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: don't set surf_index for stencil-only images

[Rhys Perry]

Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)')
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116
Signed-off-by: Rhys Perry 
---
Unfortunately I was not able to test this patch on a Polaris due to hardware
issues. It fixed the deqp-vk tests mentioned in the bugzilla without regressions
on Vega though.

 src/amd/vulkan/radv_image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 2cff4d5283..2bd74e202f 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -986,7 +986,7 @@ radv_image_create(VkDevice _device,
 
image->shareable = vk_find_struct_const(pCreateInfo->pNext,

EXTERNAL_MEMORY_IMAGE_CREATE_INFO_KHR) != NULL;
-   if (!vk_format_is_depth(pCreateInfo->format) && !create_info->scanout 
&& !image->shareable) {
+   if (!vk_format_is_depth_or_stencil(pCreateInfo->format) && 
!create_info->scanout && !image->shareable) {
image->info.surf_index = >image_mrt_offset_counter;
}
 
-- 
2.19.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev