Re: [Mesa-dev] [PATCH] radv: implement VK_AMD_shader_core_properties2

2019-08-21 Thread Bas Nieuwenhuizen
r-b

On Wed, Aug 21, 2019 at 9:01 AM Samuel Pitoiset
 wrote:
>
> Trivial extension that matches PAL.
>
> Signed-off-by: Samuel Pitoiset 
> ---
>  src/amd/vulkan/radv_device.c  | 9 +
>  src/amd/vulkan/radv_extensions.py | 1 +
>  2 files changed, 10 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index cc45ac95c08..5fde4577e4e 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -1300,6 +1300,15 @@ void radv_GetPhysicalDeviceProperties2(
> properties->vgprAllocationGranularity = 4;
> break;
> }
> +   case 
> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_CORE_PROPERTIES_2_AMD: {
> +   VkPhysicalDeviceShaderCoreProperties2AMD *properties =
> +   (VkPhysicalDeviceShaderCoreProperties2AMD 
> *)ext;
> +
> +   properties->shaderCoreFeatures = 0;
> +   properties->activeComputeUnitCount =
> +   pdevice->rad_info.num_good_compute_units;
> +   break;
> +   }
> case 
> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VERTEX_ATTRIBUTE_DIVISOR_PROPERTIES_EXT: {
> VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT 
> *properties =
> 
> (VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT *)ext;
> diff --git a/src/amd/vulkan/radv_extensions.py 
> b/src/amd/vulkan/radv_extensions.py
> index 3624970dd37..b28d74f5746 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -143,6 +143,7 @@ EXTENSIONS = [
>  Extension('VK_AMD_rasterization_order',   1, 
> 'device->has_out_of_order_rast'),
>  Extension('VK_AMD_shader_ballot', 1, 
> 'device->use_shader_ballot'),
>  Extension('VK_AMD_shader_core_properties',1, True),
> +Extension('VK_AMD_shader_core_properties2',   1, True),
>  Extension('VK_AMD_shader_info',   1, True),
>  Extension('VK_AMD_shader_trinary_minmax', 1, True),
>  Extension('VK_GOOGLE_decorate_string',1, True),
> --
> 2.22.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: implement VK_AMD_shader_core_properties2

2019-08-21 Thread Samuel Pitoiset
Trivial extension that matches PAL.

Signed-off-by: Samuel Pitoiset 
---
 src/amd/vulkan/radv_device.c  | 9 +
 src/amd/vulkan/radv_extensions.py | 1 +
 2 files changed, 10 insertions(+)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index cc45ac95c08..5fde4577e4e 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1300,6 +1300,15 @@ void radv_GetPhysicalDeviceProperties2(
properties->vgprAllocationGranularity = 4;
break;
}
+   case 
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_CORE_PROPERTIES_2_AMD: {
+   VkPhysicalDeviceShaderCoreProperties2AMD *properties =
+   (VkPhysicalDeviceShaderCoreProperties2AMD *)ext;
+
+   properties->shaderCoreFeatures = 0;
+   properties->activeComputeUnitCount =
+   pdevice->rad_info.num_good_compute_units;
+   break;
+   }
case 
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VERTEX_ATTRIBUTE_DIVISOR_PROPERTIES_EXT: {
VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT 
*properties =

(VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT *)ext;
diff --git a/src/amd/vulkan/radv_extensions.py 
b/src/amd/vulkan/radv_extensions.py
index 3624970dd37..b28d74f5746 100644
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -143,6 +143,7 @@ EXTENSIONS = [
 Extension('VK_AMD_rasterization_order',   1, 
'device->has_out_of_order_rast'),
 Extension('VK_AMD_shader_ballot', 1, 
'device->use_shader_ballot'),
 Extension('VK_AMD_shader_core_properties',1, True),
+Extension('VK_AMD_shader_core_properties2',   1, True),
 Extension('VK_AMD_shader_info',   1, True),
 Extension('VK_AMD_shader_trinary_minmax', 1, True),
 Extension('VK_GOOGLE_decorate_string',1, True),
-- 
2.22.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev