[Mesa-dev] [PATCH] scons: Warn when using MSVS versions prior to 2012.

2013-03-15 Thread jfonseca 
From: José Fonseca jfons...@vmware.com

---
 scons/gallium.py |2 ++
 1 file changed, 2 insertions(+)

diff --git a/scons/gallium.py b/scons/gallium.py
index 4d3de82..b28be5d 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -402,6 +402,8 @@ def generate(env):
   '/Oi', # enable intrinsic functions
 ]
 else:
+if distutils.version.LooseVersion(env['MSVC_VERSION'])  
distutils.version.LooseVersion('11.0'):
+print 'scons: warning: Visual Studio versions prior to 2012 
are known to produce incorrect code when optimizations are enabled ( 
https://bugs.freedesktop.org/show_bug.cgi?id=58718 )'
 ccflags += [
 '/O2', # optimize for speed
 ]
-- 
1.7.9.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] scons: Warn when using MSVS versions prior to 2012.

2013-03-15 Thread Brian Paul 

On 03/15/2013 09:24 AM, jfons...@vmware.com wrote:

From: José Fonsecajfons...@vmware.com

---
  scons/gallium.py |2 ++
  1 file changed, 2 insertions(+)

diff --git a/scons/gallium.py b/scons/gallium.py
index 4d3de82..b28be5d 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -402,6 +402,8 @@ def generate(env):
'/Oi', # enable intrinsic functions
  ]
  else:
+if distutils.version.LooseVersion(env['MSVC_VERSION'])  
distutils.version.LooseVersion('11.0'):
+print 'scons: warning: Visual Studio versions prior to 2012 
are known to produce incorrect code when optimizations are enabled ( 
https://bugs.freedesktop.org/show_bug.cgi?id=58718 )'
  ccflags += [
  '/O2', # optimize for speed
  ]


Reviewed-by: Brian Paul bri...@vmware.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev