Re: [Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file
On 28 June 2017 at 09:33, Eric Engestrom wrote: > On Tuesday, 2017-06-27 20:58:48 -0600, Brian Paul wrote: >> Fixes broken SCons build since a1983223d8839a0c9 > > Reviewed-by: Eric Engestrom > > Btw, the format "Fixes: $sha1 [optional commit title]" allows scripts to > parse it and eg. apply to relevant stable branches. > The existing commit message (just the sha1) should get flagged by get-extra-pick-list.sh, so we're safe. Regardless, getting into the habit of using Fixes tag will be beneficial ;-) -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file
On Tuesday, 2017-06-27 20:58:48 -0600, Brian Paul wrote: > Fixes broken SCons build since a1983223d8839a0c9 Reviewed-by: Eric Engestrom Btw, the format "Fixes: $sha1 [optional commit title]" allows scripts to parse it and eg. apply to relevant stable branches. In this case: Fixes: a1983223d8839a0c9 "mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]" > --- > src/mesa/SConscript | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/SConscript b/src/mesa/SConscript > index fa4efe1..b63e15a 100644 > --- a/src/mesa/SConscript > +++ b/src/mesa/SConscript > @@ -79,6 +79,13 @@ format_unpack = env.CodeGenerate( >command = python_cmd + ' $SCRIPT ' + ' $SOURCE > $TARGET' > ) > > +format_fallback = env.CodeGenerate( > + target = 'main/format_fallback.c', > + script = 'main/format_fallback.py', > + source = 'main/formats.csv', > + command = python_cmd + ' $SCRIPT ' + ' $SOURCE ' + ' $TARGET' > +) > + > # > # Assembly sources > # > -- > 1.9.1 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file
On 28 June 2017 at 03:58, Brian Paul wrote: > Fixes broken SCons build since a1983223d8839a0c9 Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file
Looks good to me, thanks! Reviewed-by: Roland Scheidegger Am 28.06.2017 um 04:58 schrieb Brian Paul: > Fixes broken SCons build since a1983223d8839a0c9 > --- > src/mesa/SConscript | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/SConscript b/src/mesa/SConscript > index fa4efe1..b63e15a 100644 > --- a/src/mesa/SConscript > +++ b/src/mesa/SConscript > @@ -79,6 +79,13 @@ format_unpack = env.CodeGenerate( >command = python_cmd + ' $SCRIPT ' + ' $SOURCE > $TARGET' > ) > > +format_fallback = env.CodeGenerate( > + target = 'main/format_fallback.c', > + script = 'main/format_fallback.py', > + source = 'main/formats.csv', > + command = python_cmd + ' $SCRIPT ' + ' $SOURCE ' + ' $TARGET' > +) > + > # > # Assembly sources > # > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file
Fixes broken SCons build since a1983223d8839a0c9 --- src/mesa/SConscript | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index fa4efe1..b63e15a 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript @@ -79,6 +79,13 @@ format_unpack = env.CodeGenerate( command = python_cmd + ' $SCRIPT ' + ' $SOURCE > $TARGET' ) +format_fallback = env.CodeGenerate( + target = 'main/format_fallback.c', + script = 'main/format_fallback.py', + source = 'main/formats.csv', + command = python_cmd + ' $SCRIPT ' + ' $SOURCE ' + ' $TARGET' +) + # # Assembly sources # -- 1.9.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev