[Mesa-dev] [PATCH] st/mesa: Fix memory leak in out-of-memory path.

[Vinson Lee]

Fixes Coverity resource leak defect.

Signed-off-by: Vinson Lee v...@vmware.com
---
 src/mesa/state_tracker/st_atom_pixeltransfer.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/mesa/state_tracker/st_atom_pixeltransfer.c 
b/src/mesa/state_tracker/st_atom_pixeltransfer.c
index afca609..fb1e409 100644
--- a/src/mesa/state_tracker/st_atom_pixeltransfer.c
+++ b/src/mesa/state_tracker/st_atom_pixeltransfer.c
@@ -266,6 +266,7 @@ get_pixel_transfer_program(struct gl_context *ctx, const 
struct state_key *key)
if (!fp-Base.Instructions) {
   _mesa_error(ctx, GL_OUT_OF_MEMORY,
   generating pixel transfer program);
+  _mesa_free_parameter_list(params);
   return NULL;
}
 
-- 
1.7.7.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: Fix memory leak in out-of-memory path.

[Brian Paul]

On 12/16/2011 07:46 AM, Vinson Lee wrote:

Fixes Coverity resource leak defect.

Signed-off-by: Vinson Leev...@vmware.com
---
  src/mesa/state_tracker/st_atom_pixeltransfer.c |1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/mesa/state_tracker/st_atom_pixeltransfer.c 
b/src/mesa/state_tracker/st_atom_pixeltransfer.c
index afca609..fb1e409 100644
--- a/src/mesa/state_tracker/st_atom_pixeltransfer.c
+++ b/src/mesa/state_tracker/st_atom_pixeltransfer.c
@@ -266,6 +266,7 @@ get_pixel_transfer_program(struct gl_context *ctx, const 
struct state_key *key)
 if (!fp-Base.Instructions) {
_mesa_error(ctx, GL_OUT_OF_MEMORY,
generating pixel transfer program);
+  _mesa_free_parameter_list(params);
return NULL;
 }



Reviewed-by: Brian Paul bri...@vmware.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev