Re: [Mesa-dev] [PATCH] st/nine: Fix invalid attempt to use indirect draws.
Pushed. Marek On Wed, Aug 10, 2016 at 1:16 PM, trevor.davenp...@gmail.com wrote: > I don't have commit access so someone else will need to push this out. > > Trevor > > > On Aug 10, 2016 2:56 AM, "Marek Olšák" wrote: >> >> Reviewed-by: Marek Olšák >> >> Marek >> >> On Wed, Aug 10, 2016 at 5:28 AM, Trevor Davenport >> wrote: >> > Since commit 6d7177f01b231e9fe79a558c28d2b562a218d7ea, radeonsi >> > would take a different path if info->indirect_params was not >> > initialized properly. Nine was not initializating this field. >> > --- >> > src/gallium/state_trackers/nine/device9.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git src/gallium/state_trackers/nine/device9.c >> > src/gallium/state_trackers/nine/device9.c >> > index d233304..3f6577c 100644 >> > --- src/gallium/state_trackers/nine/device9.c >> > +++ src/gallium/state_trackers/nine/device9.c >> > @@ -2935,6 +2935,7 @@ init_draw_info(struct pipe_draw_info *info, >> > info->restart_index = 0; >> > info->count_from_stream_output = NULL; >> > info->indirect = NULL; >> > +info->indirect_params = NULL; >> > } >> > >> > HRESULT NINE_WINAPI >> > -- >> > 2.7.4 >> > >> > ___ >> > mesa-dev mailing list >> > mesa-dev@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nine: Fix invalid attempt to use indirect draws.
I don't have commit access so someone else will need to push this out. Trevor On Aug 10, 2016 2:56 AM, "Marek Olšák" wrote: > Reviewed-by: Marek Olšák > > Marek > > On Wed, Aug 10, 2016 at 5:28 AM, Trevor Davenport > wrote: > > Since commit 6d7177f01b231e9fe79a558c28d2b562a218d7ea, radeonsi > > would take a different path if info->indirect_params was not > > initialized properly. Nine was not initializating this field. > > --- > > src/gallium/state_trackers/nine/device9.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git src/gallium/state_trackers/nine/device9.c > src/gallium/state_trackers/nine/device9.c > > index d233304..3f6577c 100644 > > --- src/gallium/state_trackers/nine/device9.c > > +++ src/gallium/state_trackers/nine/device9.c > > @@ -2935,6 +2935,7 @@ init_draw_info(struct pipe_draw_info *info, > > info->restart_index = 0; > > info->count_from_stream_output = NULL; > > info->indirect = NULL; > > +info->indirect_params = NULL; > > } > > > > HRESULT NINE_WINAPI > > -- > > 2.7.4 > > > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nine: Fix invalid attempt to use indirect draws.
Reviewed-by: Marek Olšák Marek On Wed, Aug 10, 2016 at 5:28 AM, Trevor Davenport wrote: > Since commit 6d7177f01b231e9fe79a558c28d2b562a218d7ea, radeonsi > would take a different path if info->indirect_params was not > initialized properly. Nine was not initializating this field. > --- > src/gallium/state_trackers/nine/device9.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git src/gallium/state_trackers/nine/device9.c > src/gallium/state_trackers/nine/device9.c > index d233304..3f6577c 100644 > --- src/gallium/state_trackers/nine/device9.c > +++ src/gallium/state_trackers/nine/device9.c > @@ -2935,6 +2935,7 @@ init_draw_info(struct pipe_draw_info *info, > info->restart_index = 0; > info->count_from_stream_output = NULL; > info->indirect = NULL; > +info->indirect_params = NULL; > } > > HRESULT NINE_WINAPI > -- > 2.7.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] st/nine: Fix invalid attempt to use indirect draws.
Since commit 6d7177f01b231e9fe79a558c28d2b562a218d7ea, radeonsi would take a different path if info->indirect_params was not initialized properly. Nine was not initializating this field. --- src/gallium/state_trackers/nine/device9.c | 1 + 1 file changed, 1 insertion(+) diff --git src/gallium/state_trackers/nine/device9.c src/gallium/state_trackers/nine/device9.c index d233304..3f6577c 100644 --- src/gallium/state_trackers/nine/device9.c +++ src/gallium/state_trackers/nine/device9.c @@ -2935,6 +2935,7 @@ init_draw_info(struct pipe_draw_info *info, info->restart_index = 0; info->count_from_stream_output = NULL; info->indirect = NULL; +info->indirect_params = NULL; } HRESULT NINE_WINAPI -- 2.7.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
