[Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Thomas Hellstrom 
The mentioned commit has the nasty side-effect of turning off accelerated
copies.

Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org
Signed-off-by: Thomas Hellstrom thellst...@vmware.com
---
 src/gallium/state_trackers/xa/xa_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/xa/xa_context.c 
b/src/gallium/state_trackers/xa/xa_context.c
index 37de45b..df3043c 100644
--- a/src/gallium/state_trackers/xa/xa_context.c
+++ b/src/gallium/state_trackers/xa/xa_context.c
@@ -223,7 +223,7 @@ XA_EXPORT int
 xa_copy_prepare(struct xa_context *ctx,
struct xa_surface *dst, struct xa_surface *src)
 {
-if (src == dst || ctx-srf != NULL)
+if (src == dst)
return -XA_ERR_INVAL;
 
 if (src-tex-format != dst-tex-format) {
-- 
1.8.3.2
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Jakob Bornecrantz 
On Thu, May 8, 2014 at 9:15 AM, Thomas Hellstrom thellst...@vmware.com wrote:
 The mentioned commit has the nasty side-effect of turning off accelerated
 copies.

 Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org
 Signed-off-by: Thomas Hellstrom thellst...@vmware.com
 ---
  src/gallium/state_trackers/xa/xa_context.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Jakob Bornecrantz ja...@vmware.com

 diff --git a/src/gallium/state_trackers/xa/xa_context.c 
 b/src/gallium/state_trackers/xa/xa_context.c
 index 37de45b..df3043c 100644
 --- a/src/gallium/state_trackers/xa/xa_context.c
 +++ b/src/gallium/state_trackers/xa/xa_context.c
 @@ -223,7 +223,7 @@ XA_EXPORT int
  xa_copy_prepare(struct xa_context *ctx,
 struct xa_surface *dst, struct xa_surface *src)
  {
 -if (src == dst || ctx-srf != NULL)
 +if (src == dst)
 return -XA_ERR_INVAL;

  if (src-tex-format != dst-tex-format) {
 --
 1.8.3.2
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Jakob Bornecrantz 
On Thu, May 8, 2014 at 9:15 AM, Thomas Hellstrom thellst...@vmware.com wrote:
 The mentioned commit has the nasty side-effect of turning off accelerated
 copies.

 Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org
 Signed-off-by: Thomas Hellstrom thellst...@vmware.com
 ---
  src/gallium/state_trackers/xa/xa_context.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jakob Bornecrantz ja...@vmware.com

 diff --git a/src/gallium/state_trackers/xa/xa_context.c 
 b/src/gallium/state_trackers/xa/xa_context.c
 index 37de45b..df3043c 100644
 --- a/src/gallium/state_trackers/xa/xa_context.c
 +++ b/src/gallium/state_trackers/xa/xa_context.c
 @@ -223,7 +223,7 @@ XA_EXPORT int
  xa_copy_prepare(struct xa_context *ctx,
 struct xa_surface *dst, struct xa_surface *src)
  {
 -if (src == dst || ctx-srf != NULL)
 +if (src == dst)
 return -XA_ERR_INVAL;

  if (src-tex-format != dst-tex-format) {
 --
 1.8.3.2
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Rob Clark 
On Thu, May 8, 2014 at 3:15 AM, Thomas Hellstrom thellst...@vmware.com wrote:
 The mentioned commit has the nasty side-effect of turning off accelerated
 copies.

 Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org
 Signed-off-by: Thomas Hellstrom thellst...@vmware.com

Reviewed-by: Rob Clark robdcl...@gmail.com

 ---
  src/gallium/state_trackers/xa/xa_context.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/gallium/state_trackers/xa/xa_context.c 
 b/src/gallium/state_trackers/xa/xa_context.c
 index 37de45b..df3043c 100644
 --- a/src/gallium/state_trackers/xa/xa_context.c
 +++ b/src/gallium/state_trackers/xa/xa_context.c
 @@ -223,7 +223,7 @@ XA_EXPORT int
  xa_copy_prepare(struct xa_context *ctx,
 struct xa_surface *dst, struct xa_surface *src)
  {
 -if (src == dst || ctx-srf != NULL)
 +if (src == dst)
 return -XA_ERR_INVAL;

  if (src-tex-format != dst-tex-format) {
 --
 1.8.3.2
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev