Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-14 Thread Liu, Leo 

On 2019-05-14 5:29 a.m., Michel Dänzer wrote:
> [CAUTION: External Email]
>
> On 2019-05-09 8:10 p.m., Liu, Leo wrote:
>> Since the using output optimization is only for back buffer case
>>
>> Signed-off-by: Leo Liu 
>> ---
>>   src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c 
>> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> index 1558d832555..77d1972af2c 100644
>> --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> @@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable 
>> drawable)
>>ret = false;
>> else {
>>scrn->is_pixmap = true;
>> + scrn->base.set_back_texture_from_output = NULL;
>>if (scrn->front_buffer) {
>>   dri3_free_front_buffer(scrn, scrn->front_buffer);
>>   scrn->front_buffer = NULL;
>>
> Couldn't dri3_set_drawable be called for a pixmap first, then later for
> a window, for the same scrn?

I could not think of any of such case. AFAIK, the video is rendering 
either to window drawable as back buffer case or to pixmap drawable as 
front buffer case.

Thanks,

Leo


>
> --
> Earthling Michel Dänzer   |  https://www.amd.com
> Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-14 Thread Michel Dänzer 
On 2019-05-09 8:10 p.m., Liu, Leo wrote:
> Since the using output optimization is only for back buffer case
> 
> Signed-off-by: Leo Liu 
> ---
>  src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c 
> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> index 1558d832555..77d1972af2c 100644
> --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> @@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable 
> drawable)
>   ret = false;
>else {
>   scrn->is_pixmap = true;
> + scrn->base.set_back_texture_from_output = NULL;
>   if (scrn->front_buffer) {
>  dri3_free_front_buffer(scrn, scrn->front_buffer);
>  scrn->front_buffer = NULL;
> 

Couldn't dri3_set_drawable be called for a pixmap first, then later for
a window, for the same scrn?


-- 
Earthling Michel Dänzer   |  https://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-13 Thread Alex Deucher 
Acked-by: Alex Deucher 

On Mon, May 13, 2019 at 4:01 PM Liu, Leo  wrote:
>
> Ping...
>
> On 5/9/19 2:10 PM, Liu, Leo wrote:
> > Since the using output optimization is only for back buffer case
> >
> > Signed-off-by: Leo Liu 
> > ---
> >   src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c 
> > b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> > index 1558d832555..77d1972af2c 100644
> > --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> > +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> > @@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable 
> > drawable)
> >ret = false;
> > else {
> >scrn->is_pixmap = true;
> > + scrn->base.set_back_texture_from_output = NULL;
> >if (scrn->front_buffer) {
> >   dri3_free_front_buffer(scrn, scrn->front_buffer);
> >   scrn->front_buffer = NULL;
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-13 Thread Liu, Leo 
Ping...

On 5/9/19 2:10 PM, Liu, Leo wrote:
> Since the using output optimization is only for back buffer case
>
> Signed-off-by: Leo Liu 
> ---
>   src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c 
> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> index 1558d832555..77d1972af2c 100644
> --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> @@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable 
> drawable)
>ret = false;
> else {
>scrn->is_pixmap = true;
> + scrn->base.set_back_texture_from_output = NULL;
>if (scrn->front_buffer) {
>   dri3_free_front_buffer(scrn, scrn->front_buffer);
>   scrn->front_buffer = NULL;
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-09 Thread Liu, Leo 
Since the using output optimization is only for back buffer case

Signed-off-by: Leo Liu 
---
 src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c 
b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
index 1558d832555..77d1972af2c 100644
--- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
+++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
@@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable 
drawable)
  ret = false;
   else {
  scrn->is_pixmap = true;
+ scrn->base.set_back_texture_from_output = NULL;
  if (scrn->front_buffer) {
 dri3_free_front_buffer(scrn, scrn->front_buffer);
 scrn->front_buffer = NULL;
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev