Re: [Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe. (v2)

2012-06-04 Thread Brian Paul

On 06/01/2012 03:28 PM, Olivier Galibert wrote:

   Hi,

The following pair of patches add gl_VertexID support to llvmpipe.
They also simplify the system value fetch methodology (hopefully
generating better code in the end) and fixes some issues with
gl_InstanceID.  The I don't understand how it could ever work kind
of issues, converting from int32 to float twice is not good, usually.

v2: Fix a stupid type error for vertex id.


I haven't looked at this code in a while, but looks good AFAICT.

Reviewed-by: Brian Paul bri...@vmware.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe. (v2)

2012-06-01 Thread Olivier Galibert
  Hi,

The following pair of patches add gl_VertexID support to llvmpipe.
They also simplify the system value fetch methodology (hopefully
generating better code in the end) and fixes some issues with
gl_InstanceID.  The I don't understand how it could ever work kind
of issues, converting from int32 to float twice is not good, usually.

v2: Fix a stupid type error for vertex id.

Best,

  OG.

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev