Re: [Mesa-dev] [PATCH 0/2] Implement (viewport) system values
> If we use the sysval, at least 1 is driver spec, 2 can be shared. So could you > move 2 into the nir dir for sharing with lima? For sure, I'll try to get a patch for that this weekend :) -Alyssa ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] Implement (viewport) system values
On Sat, Apr 6, 2019 at 10:18 AM Alyssa Rosenzweig wrote: > > Hi, > > NIR system values are the preferred method of transferring state like > this around; the shared transformation pass should be agnostic to the > underlying uniforms / state tracker / etc. Is there any reason we can't > share the transform as I implement it here? (Which makes no assumptions > about uniform layout) I think there're two parts of this stuff 1. sysval uniform update 2. nir transform insert If we use the sysval, at least 1 is driver spec, 2 can be shared. So could you move 2 into the nir dir for sharing with lima? Thanks, Qiang > > Alyssa ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] Implement (viewport) system values
Hi, NIR system values are the preferred method of transferring state like this around; the shared transformation pass should be agnostic to the underlying uniforms / state tracker / etc. Is there any reason we can't share the transform as I implement it here? (Which makes no assumptions about uniform layout) Alyssa ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] Implement (viewport) system values
So you prefer to use the nir sysval method and implement a per driver version of viewport transform? As I sended out a patch series for a shared version of this transform, any feedback on it? https://patchwork.freedesktop.org/series/58618/ Regards, Qiang On Wed, Apr 3, 2019 at 9:50 AM Alyssa Rosenzweig wrote: > > This patch set implements the infrastructure for piping system values > through Panfrost, replacing the prior brittle system of magic uniform > offsets. This infrastructure is used to implement the vertex shader > viewport transformation, which will soon be shared with lima. > > Alyssa Rosenzweig (2): > nir: Add "viewport vector" system values > panfrost: Implement system values > > src/compiler/nir/nir_intrinsics.py| 5 + > src/gallium/drivers/panfrost/meson.build | 1 + > .../drivers/panfrost/midgard/helpers.h| 4 - > .../panfrost/midgard/midgard_compile.c| 272 +- > .../panfrost/midgard/midgard_compile.h| 27 +- > src/gallium/drivers/panfrost/pan_assemble.c | 5 + > src/gallium/drivers/panfrost/pan_context.c| 103 +++ > src/gallium/drivers/panfrost/pan_context.h| 5 + > 8 files changed, 234 insertions(+), 188 deletions(-) > > -- > 2.20.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/2] Implement (viewport) system values
This patch set implements the infrastructure for piping system values through Panfrost, replacing the prior brittle system of magic uniform offsets. This infrastructure is used to implement the vertex shader viewport transformation, which will soon be shared with lima. Alyssa Rosenzweig (2): nir: Add "viewport vector" system values panfrost: Implement system values src/compiler/nir/nir_intrinsics.py| 5 + src/gallium/drivers/panfrost/meson.build | 1 + .../drivers/panfrost/midgard/helpers.h| 4 - .../panfrost/midgard/midgard_compile.c| 272 +- .../panfrost/midgard/midgard_compile.h| 27 +- src/gallium/drivers/panfrost/pan_assemble.c | 5 + src/gallium/drivers/panfrost/pan_context.c| 103 +++ src/gallium/drivers/panfrost/pan_context.h| 5 + 8 files changed, 234 insertions(+), 188 deletions(-) -- 2.20.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
