Re: [Mesa-dev] [PATCH 01/13] glsl: Remove 'struct' from ir_variable declaration.

2014-06-16 Thread Tapani Pälli
This set (1..13)

Reviewed-by: Tapani Pälli tapani.pa...@intel.com

There's still some unused variables and one unused function
(svga_draw.c:294) left but this set makes build much more silent.


On 06/15/2014 08:15 PM, Matt Turner wrote:
 ---
  src/glsl/opt_dead_builtin_varyings.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/glsl/opt_dead_builtin_varyings.cpp 
 b/src/glsl/opt_dead_builtin_varyings.cpp
 index 6612592..50c8aa7 100644
 --- a/src/glsl/opt_dead_builtin_varyings.cpp
 +++ b/src/glsl/opt_dead_builtin_varyings.cpp
 @@ -334,7 +334,7 @@ public:
 }
  
 void prepare_array(exec_list *ir,
 -  struct ir_variable **new_var,
 +  ir_variable **new_var,
int max_elements, unsigned start_location,
const char *var_name, const char *mode_str,
unsigned usage, unsigned external_usage)

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 01/13] glsl: Remove 'struct' from ir_variable declaration.

2014-06-16 Thread Tapani Pälli
On 06/16/2014 09:55 AM, Tapani Pälli wrote:
 This set (1..13)

 Reviewed-by: Tapani Pälli tapani.pa...@intel.com

 There's still some unused variables and one unused function
 (svga_draw.c:294) left but this set makes build much more silent.

now I see that this func is for debugging so it is ok


 On 06/15/2014 08:15 PM, Matt Turner wrote:
 ---
  src/glsl/opt_dead_builtin_varyings.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/glsl/opt_dead_builtin_varyings.cpp 
 b/src/glsl/opt_dead_builtin_varyings.cpp
 index 6612592..50c8aa7 100644
 --- a/src/glsl/opt_dead_builtin_varyings.cpp
 +++ b/src/glsl/opt_dead_builtin_varyings.cpp
 @@ -334,7 +334,7 @@ public:
 }
  
 void prepare_array(exec_list *ir,
 -  struct ir_variable **new_var,
 +  ir_variable **new_var,
int max_elements, unsigned start_location,
const char *var_name, const char *mode_str,
unsigned usage, unsigned external_usage)
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 01/13] glsl: Remove 'struct' from ir_variable declaration.

2014-06-16 Thread Ian Romanick
Series is

Reviewed-by: Ian Romanick ian.d.roman...@intel.com

On 06/15/2014 10:15 AM, Matt Turner wrote:
 ---
  src/glsl/opt_dead_builtin_varyings.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/glsl/opt_dead_builtin_varyings.cpp 
 b/src/glsl/opt_dead_builtin_varyings.cpp
 index 6612592..50c8aa7 100644
 --- a/src/glsl/opt_dead_builtin_varyings.cpp
 +++ b/src/glsl/opt_dead_builtin_varyings.cpp
 @@ -334,7 +334,7 @@ public:
 }
  
 void prepare_array(exec_list *ir,
 -  struct ir_variable **new_var,
 +  ir_variable **new_var,
int max_elements, unsigned start_location,
const char *var_name, const char *mode_str,
unsigned usage, unsigned external_usage)
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 01/13] glsl: Remove 'struct' from ir_variable declaration.

2014-06-15 Thread Matt Turner
---
 src/glsl/opt_dead_builtin_varyings.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/glsl/opt_dead_builtin_varyings.cpp 
b/src/glsl/opt_dead_builtin_varyings.cpp
index 6612592..50c8aa7 100644
--- a/src/glsl/opt_dead_builtin_varyings.cpp
+++ b/src/glsl/opt_dead_builtin_varyings.cpp
@@ -334,7 +334,7 @@ public:
}
 
void prepare_array(exec_list *ir,
-  struct ir_variable **new_var,
+  ir_variable **new_var,
   int max_elements, unsigned start_location,
   const char *var_name, const char *mode_str,
   unsigned usage, unsigned external_usage)
-- 
1.8.3.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev