Re: [Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn
I can't seem to find the cover email, so I'll respond to this one. Aside from my comments on patches 11 and 13, patches 1-5 and 11-13 are Reviewed-by: Connor Abbott cwabbo...@gmail.com and FWIW 6-10 are Acked-by: Connor Abbott cwabbo...@gmail.com although what's important there are other people testing those and make sure they don't break other things (particularly Windows). On Tue, May 5, 2015 at 8:16 PM, Connor Abbott cwabbo...@gmail.com wrote: Typo in the subject line. On Tue, Apr 28, 2015 at 12:03 AM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/glsl/nir/nir_validate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a7aa798..35a853d 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -236,6 +236,8 @@ validate_ssa_def(nir_ssa_def *def, validate_state *state) assert(!BITSET_TEST(state-ssa_defs_found, def-index)); BITSET_SET(state-ssa_defs_found, def-index); + assert(def-parent_instr == state-instr); + assert(def-num_components = 4); ssa_def_validate_state *def_state = ralloc(state-ssa_defs, -- 2.3.6 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn
Typo in the subject line. On Tue, Apr 28, 2015 at 12:03 AM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/glsl/nir/nir_validate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a7aa798..35a853d 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -236,6 +236,8 @@ validate_ssa_def(nir_ssa_def *def, validate_state *state) assert(!BITSET_TEST(state-ssa_defs_found, def-index)); BITSET_SET(state-ssa_defs_found, def-index); + assert(def-parent_instr == state-instr); + assert(def-num_components = 4); ssa_def_validate_state *def_state = ralloc(state-ssa_defs, -- 2.3.6 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn
On Tue, May 5, 2015 at 5:16 PM, Connor Abbott cwabbo...@gmail.com wrote: Typo in the subject line. Fixed Locally --Jason ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn
--- src/glsl/nir/nir_validate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a7aa798..35a853d 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -236,6 +236,8 @@ validate_ssa_def(nir_ssa_def *def, validate_state *state) assert(!BITSET_TEST(state-ssa_defs_found, def-index)); BITSET_SET(state-ssa_defs_found, def-index); + assert(def-parent_instr == state-instr); + assert(def-num_components = 4); ssa_def_validate_state *def_state = ralloc(state-ssa_defs, -- 2.3.6 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
