Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

2014-07-07 Thread Samuel Pitoiset 

On 07/07/2014 07:15 PM, Roland Scheidegger wrote:

Oh and 2,5,6,7,8 have a somewhat bogus commit message - this is a
pipe_screen function, not pipe_context.


Oh my bad! I'm sorry...
I fixed it locally, thanks.



Roland

Am 07.07.2014 18:42, schrieb Roland Scheidegger:

You should also add docs bit in gallium/docs/source/screen.rst

Otherwise looks ok to me.

Roland

Am 07.07.2014 17:47, schrieb Samuel Pitoiset:

This will be used to sort counters per group for
GL_AMD_performance_monitor.

Signed-off-by: Samuel Pitoiset 
---
  src/gallium/include/pipe/p_defines.h |  7 +++
  src/gallium/include/pipe/p_screen.h  | 11 +++
  2 files changed, 18 insertions(+)

diff --git a/src/gallium/include/pipe/p_defines.h 
b/src/gallium/include/pipe/p_defines.h
index d9b6e5a..8f20974 100644
--- a/src/gallium/include/pipe/p_defines.h
+++ b/src/gallium/include/pipe/p_defines.h
@@ -735,6 +735,13 @@ struct pipe_driver_query_info
 boolean uses_byte_units; /* whether the result is in bytes */
  };
  
+struct pipe_driver_query_group_info

+{
+   const char *name;
+   unsigned max_active_queries;
+   unsigned num_queries;
+};
+
  #ifdef __cplusplus
  }
  #endif
diff --git a/src/gallium/include/pipe/p_screen.h 
b/src/gallium/include/pipe/p_screen.h
index cf958d2..8fc110e 100644
--- a/src/gallium/include/pipe/p_screen.h
+++ b/src/gallium/include/pipe/p_screen.h
@@ -220,6 +220,17 @@ struct pipe_screen {
  unsigned index,
  struct pipe_driver_query_info *info);
  
+   /**

+* Returns a driver-specific query group.
+*
+* If \p info is NULL, the number of available groups is returned.
+* Otherwise, the driver query group at the specified \p index is returned
+* in \p info. The function returns non-zero on success.
+*/
+   int (*get_driver_query_group_info)(struct pipe_screen *screen,
+  unsigned index,
+  struct pipe_driver_query_group_info 
*info);
+
  };
  
  



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

2014-07-07 Thread Roland Scheidegger 
Oh and 2,5,6,7,8 have a somewhat bogus commit message - this is a
pipe_screen function, not pipe_context.

Roland

Am 07.07.2014 18:42, schrieb Roland Scheidegger:
> You should also add docs bit in gallium/docs/source/screen.rst
> 
> Otherwise looks ok to me.
> 
> Roland
> 
> Am 07.07.2014 17:47, schrieb Samuel Pitoiset:
>> This will be used to sort counters per group for
>> GL_AMD_performance_monitor.
>>
>> Signed-off-by: Samuel Pitoiset 
>> ---
>>  src/gallium/include/pipe/p_defines.h |  7 +++
>>  src/gallium/include/pipe/p_screen.h  | 11 +++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/src/gallium/include/pipe/p_defines.h 
>> b/src/gallium/include/pipe/p_defines.h
>> index d9b6e5a..8f20974 100644
>> --- a/src/gallium/include/pipe/p_defines.h
>> +++ b/src/gallium/include/pipe/p_defines.h
>> @@ -735,6 +735,13 @@ struct pipe_driver_query_info
>> boolean uses_byte_units; /* whether the result is in bytes */
>>  };
>>  
>> +struct pipe_driver_query_group_info
>> +{
>> +   const char *name;
>> +   unsigned max_active_queries;
>> +   unsigned num_queries;
>> +};
>> +
>>  #ifdef __cplusplus
>>  }
>>  #endif
>> diff --git a/src/gallium/include/pipe/p_screen.h 
>> b/src/gallium/include/pipe/p_screen.h
>> index cf958d2..8fc110e 100644
>> --- a/src/gallium/include/pipe/p_screen.h
>> +++ b/src/gallium/include/pipe/p_screen.h
>> @@ -220,6 +220,17 @@ struct pipe_screen {
>>  unsigned index,
>>  struct pipe_driver_query_info *info);
>>  
>> +   /**
>> +* Returns a driver-specific query group.
>> +*
>> +* If \p info is NULL, the number of available groups is returned.
>> +* Otherwise, the driver query group at the specified \p index is 
>> returned
>> +* in \p info. The function returns non-zero on success.
>> +*/
>> +   int (*get_driver_query_group_info)(struct pipe_screen *screen,
>> +  unsigned index,
>> +  struct pipe_driver_query_group_info 
>> *info);
>> +
>>  };
>>  
>>  
>>
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

2014-07-07 Thread Roland Scheidegger 
You should also add docs bit in gallium/docs/source/screen.rst

Otherwise looks ok to me.

Roland

Am 07.07.2014 17:47, schrieb Samuel Pitoiset:
> This will be used to sort counters per group for
> GL_AMD_performance_monitor.
> 
> Signed-off-by: Samuel Pitoiset 
> ---
>  src/gallium/include/pipe/p_defines.h |  7 +++
>  src/gallium/include/pipe/p_screen.h  | 11 +++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/src/gallium/include/pipe/p_defines.h 
> b/src/gallium/include/pipe/p_defines.h
> index d9b6e5a..8f20974 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -735,6 +735,13 @@ struct pipe_driver_query_info
> boolean uses_byte_units; /* whether the result is in bytes */
>  };
>  
> +struct pipe_driver_query_group_info
> +{
> +   const char *name;
> +   unsigned max_active_queries;
> +   unsigned num_queries;
> +};
> +
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/src/gallium/include/pipe/p_screen.h 
> b/src/gallium/include/pipe/p_screen.h
> index cf958d2..8fc110e 100644
> --- a/src/gallium/include/pipe/p_screen.h
> +++ b/src/gallium/include/pipe/p_screen.h
> @@ -220,6 +220,17 @@ struct pipe_screen {
>  unsigned index,
>  struct pipe_driver_query_info *info);
>  
> +   /**
> +* Returns a driver-specific query group.
> +*
> +* If \p info is NULL, the number of available groups is returned.
> +* Otherwise, the driver query group at the specified \p index is returned
> +* in \p info. The function returns non-zero on success.
> +*/
> +   int (*get_driver_query_group_info)(struct pipe_screen *screen,
> +  unsigned index,
> +  struct pipe_driver_query_group_info 
> *info);
> +
>  };
>  
>  
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

2014-07-07 Thread Samuel Pitoiset 
This will be used to sort counters per group for
GL_AMD_performance_monitor.

Signed-off-by: Samuel Pitoiset 
---
 src/gallium/include/pipe/p_defines.h |  7 +++
 src/gallium/include/pipe/p_screen.h  | 11 +++
 2 files changed, 18 insertions(+)

diff --git a/src/gallium/include/pipe/p_defines.h 
b/src/gallium/include/pipe/p_defines.h
index d9b6e5a..8f20974 100644
--- a/src/gallium/include/pipe/p_defines.h
+++ b/src/gallium/include/pipe/p_defines.h
@@ -735,6 +735,13 @@ struct pipe_driver_query_info
boolean uses_byte_units; /* whether the result is in bytes */
 };
 
+struct pipe_driver_query_group_info
+{
+   const char *name;
+   unsigned max_active_queries;
+   unsigned num_queries;
+};
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/src/gallium/include/pipe/p_screen.h 
b/src/gallium/include/pipe/p_screen.h
index cf958d2..8fc110e 100644
--- a/src/gallium/include/pipe/p_screen.h
+++ b/src/gallium/include/pipe/p_screen.h
@@ -220,6 +220,17 @@ struct pipe_screen {
 unsigned index,
 struct pipe_driver_query_info *info);
 
+   /**
+* Returns a driver-specific query group.
+*
+* If \p info is NULL, the number of available groups is returned.
+* Otherwise, the driver query group at the specified \p index is returned
+* in \p info. The function returns non-zero on success.
+*/
+   int (*get_driver_query_group_info)(struct pipe_screen *screen,
+  unsigned index,
+  struct pipe_driver_query_group_info 
*info);
+
 };
 
 
-- 
2.0.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev