Re: [Mesa-dev] [PATCH 04/11] i965: Handle miptree creation failure in intel_alloc_texture_storage()

[Ian Romanick]

Reviewed-by: Ian Romanick ian.d.roman...@intel.com

On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
 Check intel_miptree_create() return value before using it as
 a pointer.
 
 Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
 ---
  src/mesa/drivers/dri/i965/intel_tex.c | 3 +++
  1 file changed, 3 insertions(+)
 
 diff --git a/src/mesa/drivers/dri/i965/intel_tex.c 
 b/src/mesa/drivers/dri/i965/intel_tex.c
 index f18ca45..556b787 100644
 --- a/src/mesa/drivers/dri/i965/intel_tex.c
 +++ b/src/mesa/drivers/dri/i965/intel_tex.c
 @@ -147,6 +147,9 @@ intel_alloc_texture_storage(struct gl_context *ctx,
num_samples,
INTEL_MIPTREE_TILING_ANY);
  
 +  if (intel_texobj-mt == NULL) {
 + return false;
 +  }
 }
  
 for (face = 0; face  numFaces; face++) {
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 04/11] i965: Handle miptree creation failure in intel_alloc_texture_storage()

[Juha-Pekka Heikkila]

Check intel_miptree_create() return value before using it as
a pointer.

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
 src/mesa/drivers/dri/i965/intel_tex.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/intel_tex.c 
b/src/mesa/drivers/dri/i965/intel_tex.c
index f18ca45..556b787 100644
--- a/src/mesa/drivers/dri/i965/intel_tex.c
+++ b/src/mesa/drivers/dri/i965/intel_tex.c
@@ -147,6 +147,9 @@ intel_alloc_texture_storage(struct gl_context *ctx,
   num_samples,
   INTEL_MIPTREE_TILING_ANY);
 
+  if (intel_texobj-mt == NULL) {
+ return false;
+  }
}
 
for (face = 0; face  numFaces; face++) {
-- 
1.8.1.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev