Re: [Mesa-dev] [PATCH 09/10] anv/icl: Enable float blend optimization

[Jason Ekstrand]

On Fri, Feb 16, 2018 at 9:44 AM, Anuj Phogat  wrote:

> On Thu, Feb 15, 2018 at 6:13 PM, Jason Ekstrand 
> wrote:
> > On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat 
> wrote:
> >>
> >> Signed-off-by: Anuj Phogat 
> >> ---
> >>  src/intel/vulkan/genX_state.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/intel/vulkan/genX_state.c
> b/src/intel/vulkan/genX_state.c
> >> index 54fb8634fd..f39508034f 100644
> >> --- a/src/intel/vulkan/genX_state.c
> >> +++ b/src/intel/vulkan/genX_state.c
> >> @@ -121,7 +121,7 @@ genX(init_device_state)(struct anv_device *device)
> >> }
> >>  #endif
> >>
> >> -#if GEN_GEN == 10
> >> +#if GEN_GEN == 10 || GEN_GEN == 11
> >
> >
> > Might as well make this GEN_GEN >= 10
> >
> I can see this bit going away in future generation. So, let's keep
> the check unchanged.
>

That's fine, I guess.


> >>
> >> uint32_t cache_mode_ss;
> >> anv_pack_struct(_mode_ss, GENX(CACHE_MODE_SS),
> >> .FloatBlendOptimizationEnable = true,
> >> --
> >> 2.13.6
> >>
> >> ___
> >> mesa-dev mailing list
> >> mesa-dev@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> >
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/10] anv/icl: Enable float blend optimization

[Anuj Phogat]

On Thu, Feb 15, 2018 at 6:13 PM, Jason Ekstrand  wrote:
> On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat  wrote:
>>
>> Signed-off-by: Anuj Phogat 
>> ---
>>  src/intel/vulkan/genX_state.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
>> index 54fb8634fd..f39508034f 100644
>> --- a/src/intel/vulkan/genX_state.c
>> +++ b/src/intel/vulkan/genX_state.c
>> @@ -121,7 +121,7 @@ genX(init_device_state)(struct anv_device *device)
>> }
>>  #endif
>>
>> -#if GEN_GEN == 10
>> +#if GEN_GEN == 10 || GEN_GEN == 11
>
>
> Might as well make this GEN_GEN >= 10
>
I can see this bit going away in future generation. So, let's keep
the check unchanged.

>>
>> uint32_t cache_mode_ss;
>> anv_pack_struct(_mode_ss, GENX(CACHE_MODE_SS),
>> .FloatBlendOptimizationEnable = true,
>> --
>> 2.13.6
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/10] anv/icl: Enable float blend optimization

[Jason Ekstrand]

On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat  wrote:

> Signed-off-by: Anuj Phogat 
> ---
>  src/intel/vulkan/genX_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
> index 54fb8634fd..f39508034f 100644
> --- a/src/intel/vulkan/genX_state.c
> +++ b/src/intel/vulkan/genX_state.c
> @@ -121,7 +121,7 @@ genX(init_device_state)(struct anv_device *device)
> }
>  #endif
>
> -#if GEN_GEN == 10
> +#if GEN_GEN == 10 || GEN_GEN == 11
>

Might as well make this GEN_GEN >= 10


> uint32_t cache_mode_ss;
> anv_pack_struct(_mode_ss, GENX(CACHE_MODE_SS),
> .FloatBlendOptimizationEnable = true,
> --
> 2.13.6
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 09/10] anv/icl: Enable float blend optimization

[Anuj Phogat]

Signed-off-by: Anuj Phogat 
---
 src/intel/vulkan/genX_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
index 54fb8634fd..f39508034f 100644
--- a/src/intel/vulkan/genX_state.c
+++ b/src/intel/vulkan/genX_state.c
@@ -121,7 +121,7 @@ genX(init_device_state)(struct anv_device *device)
}
 #endif
 
-#if GEN_GEN == 10
+#if GEN_GEN == 10 || GEN_GEN == 11
uint32_t cache_mode_ss;
anv_pack_struct(_mode_ss, GENX(CACHE_MODE_SS),
.FloatBlendOptimizationEnable = true,
-- 
2.13.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev