Re: [Mesa-dev] [PATCH 09/11] gtest: Build it only for 'make check'.

2013-01-12 Thread Andreas Boll
Reviewed-by: Andreas Boll andreas.boll@gmail.com

2013/1/12 Johannes Obermayr johannesoberm...@gmx.de:
 ---
  src/gtest/Makefile.am |2 +-
  1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)

 diff --git a/src/gtest/Makefile.am b/src/gtest/Makefile.am
 index 7defa34..4188c6b 100644
 --- a/src/gtest/Makefile.am
 +++ b/src/gtest/Makefile.am
 @@ -22,7 +22,7 @@
  AM_CFLAGS = $(DEFINES) -I$(top_srcdir)/src/gtest/include
  AM_CXXFLAGS = $(DEFINES) -I$(top_srcdir)/src/gtest/include

 -noinst_LTLIBRARIES = libgtest.la
 +check_LTLIBRARIES = libgtest.la

  libgtest_la_SOURCES = \
 src/gtest-all.cc \
 --
 1.7.10.4

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 09/11] gtest: Build it only for 'make check'.

2013-01-11 Thread Johannes Obermayr
---
 src/gtest/Makefile.am |2 +-
 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)

diff --git a/src/gtest/Makefile.am b/src/gtest/Makefile.am
index 7defa34..4188c6b 100644
--- a/src/gtest/Makefile.am
+++ b/src/gtest/Makefile.am
@@ -22,7 +22,7 @@
 AM_CFLAGS = $(DEFINES) -I$(top_srcdir)/src/gtest/include
 AM_CXXFLAGS = $(DEFINES) -I$(top_srcdir)/src/gtest/include
 
-noinst_LTLIBRARIES = libgtest.la
+check_LTLIBRARIES = libgtest.la
 
 libgtest_la_SOURCES = \
src/gtest-all.cc \
-- 
1.7.10.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 09/11] gtest: Build it only for 'make check'.

2013-01-11 Thread Kenneth Graunke

On 01/11/2013 06:23 PM, Johannes Obermayr wrote:

---
  src/gtest/Makefile.am |2 +-
  1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)

diff --git a/src/gtest/Makefile.am b/src/gtest/Makefile.am
index 7defa34..4188c6b 100644
--- a/src/gtest/Makefile.am
+++ b/src/gtest/Makefile.am
@@ -22,7 +22,7 @@
  AM_CFLAGS = $(DEFINES) -I$(top_srcdir)/src/gtest/include
  AM_CXXFLAGS = $(DEFINES) -I$(top_srcdir)/src/gtest/include

-noinst_LTLIBRARIES = libgtest.la
+check_LTLIBRARIES = libgtest.la

  libgtest_la_SOURCES = \
src/gtest-all.cc \


Good call.

This patch is:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev