Re: [Mesa-dev] [PATCH 09/16] i965/icl: Update the comment for maximum number of threads per PSD

[Kenneth Graunke]

On Tuesday, February 13, 2018 11:15:09 AM PST Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat 
> ---
>  src/intel/blorp/blorp_genX_exec.h | 9 +
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 9 +
>  2 files changed, 10 insertions(+), 8 deletions(-)

Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 09/16] i965/icl: Update the comment for maximum number of threads per PSD

[Anuj Phogat]

Signed-off-by: Anuj Phogat 
---
 src/intel/blorp/blorp_genX_exec.h | 9 +
 src/mesa/drivers/dri/i965/genX_state_upload.c | 9 +
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/intel/blorp/blorp_genX_exec.h 
b/src/intel/blorp/blorp_genX_exec.h
index 7420b9d91a..85cd74f915 100644
--- a/src/intel/blorp/blorp_genX_exec.h
+++ b/src/intel/blorp/blorp_genX_exec.h
@@ -738,11 +738,12 @@ blorp_emit_ps_config(struct blorp_batch *batch,
 params->wm_prog_kernel + prog_data->prog_offset_2;
   }
 
-  /* 3DSTATE_PS expects the number of threads per PSD, which is always 64;
-   * it implicitly scales for different GT levels (which have some # of
-   * PSDs).
+  /* 3DSTATE_PS expects the number of threads per PSD, which is always 64
+   * for pre Gen11 and 128 for gen11+; On gen11+ If a programmed value is
+   * k, it implies 2(k+1) threads. It implicitly scales for different GT
+   * levels (which have some # of PSDs).
*
-   * In Gen8 the format is U8-2 whereas in Gen9 it is U8-1.
+   * In Gen8 the format is U8-2 whereas in Gen9+ it is U9-1.
*/
   if (GEN_GEN >= 9)
  ps.MaximumNumberofThreadsPerPSD = 64 - 1;
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index 29739ba051..f4463d54ae 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -3809,11 +3809,12 @@ genX(upload_ps)(struct brw_context *brw)
   ps.SampleMask = genX(determine_sample_mask(brw));
 #endif
 
-  /* 3DSTATE_PS expects the number of threads per PSD, which is always 64;
-   * it implicitly scales for different GT levels (which have some # of
-   * PSDs).
+  /* 3DSTATE_PS expects the number of threads per PSD, which is always 64
+   * for pre Gen11 and 128 for gen11+; On gen11+ If a programmed value is
+   * k, it implies 2(k+1) threads. It implicitly scales for different GT
+   * levels (which have some # of PSDs).
*
-   * In Gen8 the format is U8-2 whereas in Gen9 it is U8-1.
+   * In Gen8 the format is U8-2 whereas in Gen9+ it is U9-1.
*/
 #if GEN_GEN >= 9
   ps.MaximumNumberofThreadsPerPSD = 64 - 1;
-- 
2.13.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev