Re: [Mesa-dev] [PATCH 1/2] freedreno: use fd_bc_alloc_batch instead of fd_batch_create.

2018-10-24 Thread Rob Clark 
On Tue, Oct 23, 2018 at 9:57 PM Hyunjun Ko  wrote:
>
> Following the commit 2385d7b066 and 8e798e28f7, for resource dependancy
> tracking.
>
> Fixes: 
> dEQP-GLES31.functional.image_load_store.early_fragment_tests.no_early_fragment_tests_depth_fbo
> with FD_MESA_DEBUG=inorder

Reviewed-by: Rob Clark 

> ---
>  src/gallium/drivers/freedreno/a5xx/fd5_blitter.c | 2 +-
>  src/gallium/drivers/freedreno/freedreno_batch.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c 
> b/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c
> index 6e8177d344..09ff2b71ec 100644
> --- a/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c
> +++ b/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c
> @@ -459,7 +459,7 @@ fd5_blitter_blit(struct fd_context *ctx, const struct 
> pipe_blit_info *info)
> return;
> }
>
> -   batch = fd_batch_create(ctx, true);
> +   batch = fd_bc_alloc_batch(>screen->batch_cache, ctx, true);
>
> fd5_emit_restore(batch, batch->draw);
> fd5_emit_lrz_flush(batch->draw);
> diff --git a/src/gallium/drivers/freedreno/freedreno_batch.c 
> b/src/gallium/drivers/freedreno/freedreno_batch.c
> index 487176cc63..c83466d176 100644
> --- a/src/gallium/drivers/freedreno/freedreno_batch.c
> +++ b/src/gallium/drivers/freedreno/freedreno_batch.c
> @@ -360,7 +360,7 @@ fd_batch_flush(struct fd_batch *batch, bool sync, bool 
> force)
>  */
> new_batch = NULL;
> } else {
> -   new_batch = fd_batch_create(ctx, false);
> +   new_batch = 
> fd_bc_alloc_batch(>screen->batch_cache, ctx, false);
> util_copy_framebuffer_state(_batch->framebuffer, 
> >framebuffer);
> }
>
> --
> 2.17.1
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] freedreno: use fd_bc_alloc_batch instead of fd_batch_create.

2018-10-23 Thread Hyunjun Ko 
Following the commit 2385d7b066 and 8e798e28f7, for resource dependancy
tracking.

Fixes: 
dEQP-GLES31.functional.image_load_store.early_fragment_tests.no_early_fragment_tests_depth_fbo
with FD_MESA_DEBUG=inorder
---
 src/gallium/drivers/freedreno/a5xx/fd5_blitter.c | 2 +-
 src/gallium/drivers/freedreno/freedreno_batch.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c 
b/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c
index 6e8177d344..09ff2b71ec 100644
--- a/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c
+++ b/src/gallium/drivers/freedreno/a5xx/fd5_blitter.c
@@ -459,7 +459,7 @@ fd5_blitter_blit(struct fd_context *ctx, const struct 
pipe_blit_info *info)
return;
}
 
-   batch = fd_batch_create(ctx, true);
+   batch = fd_bc_alloc_batch(>screen->batch_cache, ctx, true);
 
fd5_emit_restore(batch, batch->draw);
fd5_emit_lrz_flush(batch->draw);
diff --git a/src/gallium/drivers/freedreno/freedreno_batch.c 
b/src/gallium/drivers/freedreno/freedreno_batch.c
index 487176cc63..c83466d176 100644
--- a/src/gallium/drivers/freedreno/freedreno_batch.c
+++ b/src/gallium/drivers/freedreno/freedreno_batch.c
@@ -360,7 +360,7 @@ fd_batch_flush(struct fd_batch *batch, bool sync, bool 
force)
 */
new_batch = NULL;
} else {
-   new_batch = fd_batch_create(ctx, false);
+   new_batch = 
fd_bc_alloc_batch(>screen->batch_cache, ctx, false);
util_copy_framebuffer_state(_batch->framebuffer, 
>framebuffer);
}
 
-- 
2.17.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev