Re: [Mesa-dev] [PATCH 1/2] glsl: remove placeholder comment

[Samuel Pitoiset]

Series is:

Reviewed-by: Samuel Pitoiset 

On 07/21/2017 06:30 AM, Timothy Arceri wrote:

This was added in 2d03f48a65a666 and seems like it was intended
as a TODO comment in a function stub rather than a useful
code comment.
---
  src/compiler/glsl/ast_to_hir.cpp | 4 
  1 file changed, 4 deletions(-)

diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index c338ad7..7de164c 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -7677,10 +7677,6 @@ ast_interface_block::hir(exec_list *instructions,
 "invalid qualifier for block",
 this->block_name);
  
-   /* The ast_interface_block has a list of ast_declarator_lists.  We

-* need to turn those into ir_variables with an association
-* with this uniform block.
-*/
 enum glsl_interface_packing packing;
 if (this->layout.flags.q.shared) {
packing = GLSL_INTERFACE_PACKING_SHARED;


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] glsl: remove placeholder comment

[Timothy Arceri]

This was added in 2d03f48a65a666 and seems like it was intended
as a TODO comment in a function stub rather than a useful
code comment.
---
 src/compiler/glsl/ast_to_hir.cpp | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index c338ad7..7de164c 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -7677,10 +7677,6 @@ ast_interface_block::hir(exec_list *instructions,
"invalid qualifier for block",
this->block_name);
 
-   /* The ast_interface_block has a list of ast_declarator_lists.  We
-* need to turn those into ir_variables with an association
-* with this uniform block.
-*/
enum glsl_interface_packing packing;
if (this->layout.flags.q.shared) {
   packing = GLSL_INTERFACE_PACKING_SHARED;
-- 
2.9.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev