Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

[Emil Velikov]

On 13 November 2017 at 17:37, Dylan Baker  wrote:
> I believe I copied this from autotools, does it have the same restriction?
>
It doesn't. Some ~1 ago I was under the assumption you need one (hence
I sent a patch) but it got dropped.
Likely you saw that one fly-by, pardon for the confusion.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

[Dylan Baker]

I can't either, so:
Reviewed-by: Dylan Baker 

Quoting Jason Ekstrand (2017-11-13 09:43:11)
> My quick attempt at grepping configure.ac didn't turn anything up.
> 
> On Mon, Nov 13, 2017 at 9:37 AM, Dylan Baker  wrote:
> 
> I believe I copied this from autotools, does it have the same restriction?
> 
> Quoting Jason Ekstrand (2017-11-11 10:32:05)
> > It should be perfectly valid to build a completely headless Vulkan
>   river.  We don't need to require a platform.
> > ---
> >  meson.build | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 1f6658b..e4d0e0f 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -306,9 +306,6 @@ if _vulkan_drivers != ''
> >    with_intel_vk = _split.contains('intel')
> >    with_amd_vk = _split.contains('amd')
> >    with_any_vk = with_amd_vk or with_intel_vk
> > -  if not (with_platform_x11 or with_platform_wayland or
> with_platform_android)
> > -    error('Vulkan requires at least one platform (x11, wayland, 
> android)
> ')
> > -  endif
> >  endif
> >
> >  with_dri2 = (with_dri or with_any_vk) and with_dri_platform == 'drm'
> > --
> > 2.5.0.400.gff86faf
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

[Jason Ekstrand]

My quick attempt at grepping configure.ac didn't turn anything up.

On Mon, Nov 13, 2017 at 9:37 AM, Dylan Baker  wrote:

> I believe I copied this from autotools, does it have the same restriction?
>
> Quoting Jason Ekstrand (2017-11-11 10:32:05)
> > It should be perfectly valid to build a completely headless Vulkan
>   river.  We don't need to require a platform.
> > ---
> >  meson.build | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 1f6658b..e4d0e0f 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -306,9 +306,6 @@ if _vulkan_drivers != ''
> >with_intel_vk = _split.contains('intel')
> >with_amd_vk = _split.contains('amd')
> >with_any_vk = with_amd_vk or with_intel_vk
> > -  if not (with_platform_x11 or with_platform_wayland or
> with_platform_android)
> > -error('Vulkan requires at least one platform (x11, wayland,
> android)')
> > -  endif
> >  endif
> >
> >  with_dri2 = (with_dri or with_any_vk) and with_dri_platform == 'drm'
> > --
> > 2.5.0.400.gff86faf
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

[Dylan Baker]

I believe I copied this from autotools, does it have the same restriction?

Quoting Jason Ekstrand (2017-11-11 10:32:05)
> It should be perfectly valid to build a completely headless Vulkan
> driver.  We don't need to require a platform.
> ---
>  meson.build | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 1f6658b..e4d0e0f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -306,9 +306,6 @@ if _vulkan_drivers != ''
>with_intel_vk = _split.contains('intel')
>with_amd_vk = _split.contains('amd')
>with_any_vk = with_amd_vk or with_intel_vk
> -  if not (with_platform_x11 or with_platform_wayland or 
> with_platform_android)
> -error('Vulkan requires at least one platform (x11, wayland, android)')
> -  endif
>  endif
>  
>  with_dri2 = (with_dri or with_any_vk) and with_dri_platform == 'drm'
> -- 
> 2.5.0.400.gff86faf
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

[Jason Ekstrand]

It should be perfectly valid to build a completely headless Vulkan
driver.  We don't need to require a platform.
---
 meson.build | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meson.build b/meson.build
index 1f6658b..e4d0e0f 100644
--- a/meson.build
+++ b/meson.build
@@ -306,9 +306,6 @@ if _vulkan_drivers != ''
   with_intel_vk = _split.contains('intel')
   with_amd_vk = _split.contains('amd')
   with_any_vk = with_amd_vk or with_intel_vk
-  if not (with_platform_x11 or with_platform_wayland or with_platform_android)
-error('Vulkan requires at least one platform (x11, wayland, android)')
-  endif
 endif
 
 with_dri2 = (with_dri or with_any_vk) and with_dri_platform == 'drm'
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev