Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-21 Thread Ian Romanick 
On 09/20/2017 09:15 PM, Timothy Arceri wrote:
> Fix sent:
> 
> https://lists.freedesktop.org/archives/mesa-dev/2017-September/170304.html

Ugh... which I already deleted from my inbox due to the tag. :(

I'll bet this fixes https://bugs.freedesktop.org/show_bug.cgi?id=102910.

That patch is

Reviewed-by: Ian Romanick 

> On 21/09/17 11:09, Timothy Arceri wrote:
>> Hi Ian,
>>
>> This series causes massive memory use in the glsl_to_tgsi pass for
>> gallium drivers. For example with the following test:
>>
>> ./bin/shader_runner_gles3
>> tests/spec/glsl-es-3.00/execution/varying-struct-copy-return-vs.shader_test
>> -auto
>>
>>
>> I'm not sure whats going on yet because it crashes my machine so
>> quickly. It seems like it may be getting stuck somewhere in this code:
>>
>> ==24131==by 0xB5E9A6F:
>> glsl_to_tgsi_visitor::emit_asm(ir_instruction*, unsigned int,
>> st_dst_reg, st_dst_reg, st_src_reg, st_src_reg, st_src_reg,
>> st_src_reg) (st_glsl_to_tgsi.cpp:397)
>> ==24131==by 0xB5EC9E6: emit_asm (st_glsl_to_tgsi.cpp:612)
>> ==24131==by 0xB5EC9E6: glsl_to_tgsi_visitor::visit(ir_constant*)
>> (st_glsl_to_tgsi.cpp:3058)
>> ==24131==by 0xB5F51C3: glsl_to_tgsi_visitor::visit(ir_assignment*)
>> (st_glsl_to_tgsi.cpp:2932)
>> ==24131==by 0xB5E45D3: glsl_to_tgsi_visitor::visit(ir_function*)
>> (st_glsl_to_tgsi.cpp:1185)
>> ==24131==by 0xB6BD2D0: visit_exec_list(exec_list*, ir_visitor*)
>> (ir.cpp:1900)
>> ==24131==by 0xB5FE312: get_mesa_program_tgsi
>> (st_glsl_to_tgsi.cpp:6559)
>> ==24131==by 0xB5FE312: st_link_shader (st_glsl_to_tgsi.cpp:6906)
>> ==24131==by 0xB622A0F: _mesa_glsl_link_shader (ir_to_mesa.cpp:3118)
>> ==24131==by 0xB52D7CA: link_program (shaderapi.c:1171)
>> ==24131==by 0xB52D7CA: link_program_error (shaderapi.c:1249)
>> ==24131==by 0x4F0B65A: stub_glLinkProgram
>> (piglit-dispatch-gen.c:33822)
>> ==24131==by 0x407A67: link_and_use_shaders (shader_runner.c:1086)
>> ==24131==by 0x410601: init_test (shader_runner.c:3855)
>>
>>
>> Tim
>>
>> On 13/09/17 02:41, Ian Romanick wrote:
>>> From: Ian Romanick 
>>>
>>> glsl/ast_type.cpp: In function ‘void
>>> merge_bindless_qualifier(YYLTYPE*, _mesa_glsl_parse_state*, const
>>> ast_type_qualifier&, const ast_type_qualifier&)’:
>>> glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’
>>> [-Wunused-parameter]
>>>   merge_bindless_qualifier(YYLTYPE *loc,
>>> ^~~
>>> glsl/ast_type.cpp:191:52: warning: unused parameter ‘qualifier’
>>> [-Wunused-parameter]
>>>const ast_type_qualifier ,
>>>  ^
>>> glsl/ast_type.cpp:192:52: warning: unused parameter ‘new_qualifier’
>>> [-Wunused-parameter]
>>>const ast_type_qualifier _qualifier)
>>>  ^
>>>
>>> glsl/ir_constant_expression.cpp: In member function ‘virtual
>>> ir_constant* ir_rvalue::constant_expression_value(void*, hash_table*)’:
>>> glsl/ir_constant_expression.cpp:512:44: warning: unused parameter
>>> ‘mem_ctx’ [-Wunused-parameter]
>>>   ir_rvalue::constant_expression_value(void *mem_ctx, struct
>>> hash_table *)
>>>  ^~~
>>> glsl/ir_constant_expression.cpp: In member function ‘virtual
>>> ir_constant* ir_texture::constant_expression_value(void*, hash_table*)’:
>>> glsl/ir_constant_expression.cpp:705:45: warning: unused parameter
>>> ‘mem_ctx’ [-Wunused-parameter]
>>>   ir_texture::constant_expression_value(void *mem_ctx, struct
>>> hash_table *)
>>>   ^~~
>>> glsl/ir_constant_expression.cpp: In member function ‘virtual
>>> ir_constant* ir_assignment::constant_expression_value(void*,
>>> hash_table*)’:
>>> glsl/ir_constant_expression.cpp:851:48: warning: unused parameter
>>> ‘mem_ctx’ [-Wunused-parameter]
>>>   ir_assignment::constant_expression_value(void *mem_ctx, struct
>>> hash_table *)
>>>  ^~~
>>> glsl/ir_constant_expression.cpp: In member function ‘virtual
>>> ir_constant* ir_constant::constant_expression_value(void*,
>>> hash_table*)’:
>>> glsl/ir_constant_expression.cpp:859:46: warning: unused parameter
>>> ‘mem_ctx’ [-Wunused-parameter]
>>>   ir_constant::constant_expression_value(void *mem_ctx, struct
>>> hash_table *)
>>>^~~
>>>
>>> glsl/linker.cpp: In function ‘void
>>> link_xfb_stride_layout_qualifiers(gl_context*, gl_shader_program*,
>>> gl_linked_shader*, gl_shader**, unsigned int)’:
>>> glsl/linker.cpp:1655:60: warning: unused parameter ‘linked_shader’
>>> [-Wunused-parameter]
>>> struct gl_linked_shader
>>> *linked_shader,
>>> 
>>> ^
>>> glsl/linker.cpp: In function ‘void
>>>

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-20 Thread Timothy Arceri 

Fix sent:

https://lists.freedesktop.org/archives/mesa-dev/2017-September/170304.html

On 21/09/17 11:09, Timothy Arceri wrote:

Hi Ian,

This series causes massive memory use in the glsl_to_tgsi pass for 
gallium drivers. For example with the following test:


./bin/shader_runner_gles3 
tests/spec/glsl-es-3.00/execution/varying-struct-copy-return-vs.shader_test 
-auto



I'm not sure whats going on yet because it crashes my machine so 
quickly. It seems like it may be getting stuck somewhere in this code:


==24131==    by 0xB5E9A6F: 
glsl_to_tgsi_visitor::emit_asm(ir_instruction*, unsigned int, 
st_dst_reg, st_dst_reg, st_src_reg, st_src_reg, st_src_reg, st_src_reg) 
(st_glsl_to_tgsi.cpp:397)

==24131==    by 0xB5EC9E6: emit_asm (st_glsl_to_tgsi.cpp:612)
==24131==    by 0xB5EC9E6: glsl_to_tgsi_visitor::visit(ir_constant*) 
(st_glsl_to_tgsi.cpp:3058)
==24131==    by 0xB5F51C3: glsl_to_tgsi_visitor::visit(ir_assignment*) 
(st_glsl_to_tgsi.cpp:2932)
==24131==    by 0xB5E45D3: glsl_to_tgsi_visitor::visit(ir_function*) 
(st_glsl_to_tgsi.cpp:1185)
==24131==    by 0xB6BD2D0: visit_exec_list(exec_list*, ir_visitor*) 
(ir.cpp:1900)

==24131==    by 0xB5FE312: get_mesa_program_tgsi (st_glsl_to_tgsi.cpp:6559)
==24131==    by 0xB5FE312: st_link_shader (st_glsl_to_tgsi.cpp:6906)
==24131==    by 0xB622A0F: _mesa_glsl_link_shader (ir_to_mesa.cpp:3118)
==24131==    by 0xB52D7CA: link_program (shaderapi.c:1171)
==24131==    by 0xB52D7CA: link_program_error (shaderapi.c:1249)
==24131==    by 0x4F0B65A: stub_glLinkProgram (piglit-dispatch-gen.c:33822)
==24131==    by 0x407A67: link_and_use_shaders (shader_runner.c:1086)
==24131==    by 0x410601: init_test (shader_runner.c:3855)


Tim

On 13/09/17 02:41, Ian Romanick wrote:

From: Ian Romanick 

glsl/ast_type.cpp: In function ‘void 
merge_bindless_qualifier(YYLTYPE*, _mesa_glsl_parse_state*, const 
ast_type_qualifier&, const ast_type_qualifier&)’:
glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ 
[-Wunused-parameter]

  merge_bindless_qualifier(YYLTYPE *loc,
    ^~~
glsl/ast_type.cpp:191:52: warning: unused parameter ‘qualifier’ 
[-Wunused-parameter]

   const ast_type_qualifier ,
 ^
glsl/ast_type.cpp:192:52: warning: unused parameter ‘new_qualifier’ 
[-Wunused-parameter]

   const ast_type_qualifier _qualifier)
 ^

glsl/ir_constant_expression.cpp: In member function ‘virtual 
ir_constant* ir_rvalue::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:512:44: warning: unused parameter 
‘mem_ctx’ [-Wunused-parameter]
  ir_rvalue::constant_expression_value(void *mem_ctx, struct 
hash_table *)

 ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual 
ir_constant* ir_texture::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:705:45: warning: unused parameter 
‘mem_ctx’ [-Wunused-parameter]
  ir_texture::constant_expression_value(void *mem_ctx, struct 
hash_table *)

  ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual 
ir_constant* ir_assignment::constant_expression_value(void*, 
hash_table*)’:
glsl/ir_constant_expression.cpp:851:48: warning: unused parameter 
‘mem_ctx’ [-Wunused-parameter]
  ir_assignment::constant_expression_value(void *mem_ctx, struct 
hash_table *)

 ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual 
ir_constant* ir_constant::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:859:46: warning: unused parameter 
‘mem_ctx’ [-Wunused-parameter]
  ir_constant::constant_expression_value(void *mem_ctx, struct 
hash_table *)

   ^~~

glsl/linker.cpp: In function ‘void 
link_xfb_stride_layout_qualifiers(gl_context*, gl_shader_program*, 
gl_linked_shader*, gl_shader**, unsigned int)’:
glsl/linker.cpp:1655:60: warning: unused parameter ‘linked_shader’ 
[-Wunused-parameter]
    struct gl_linked_shader 
*linked_shader,
 
^
glsl/linker.cpp: In function ‘void 
link_bindless_layout_qualifiers(gl_shader_program*, gl_program*, 
gl_shader**, unsigned int)’:
glsl/linker.cpp:1693:52: warning: unused parameter ‘gl_prog’ 
[-Wunused-parameter]

  struct gl_program *gl_prog,
 ^~~

glsl/lower_distance.cpp: In member function ‘virtual void 
{anonymous}::lower_distance_visitor_counter::handle_rvalue(ir_rvalue**)’:
glsl/lower_distance.cpp:652:59: warning: unused parameter ‘rv’ 
[-Wunused-parameter]

 

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-20 Thread Timothy Arceri 

Hi Ian,

This series causes massive memory use in the glsl_to_tgsi pass for 
gallium drivers. For example with the following test:


./bin/shader_runner_gles3 
tests/spec/glsl-es-3.00/execution/varying-struct-copy-return-vs.shader_test 
-auto



I'm not sure whats going on yet because it crashes my machine so 
quickly. It seems like it may be getting stuck somewhere in this code:


==24131==by 0xB5E9A6F: 
glsl_to_tgsi_visitor::emit_asm(ir_instruction*, unsigned int, 
st_dst_reg, st_dst_reg, st_src_reg, st_src_reg, st_src_reg, st_src_reg) 
(st_glsl_to_tgsi.cpp:397)

==24131==by 0xB5EC9E6: emit_asm (st_glsl_to_tgsi.cpp:612)
==24131==by 0xB5EC9E6: glsl_to_tgsi_visitor::visit(ir_constant*) 
(st_glsl_to_tgsi.cpp:3058)
==24131==by 0xB5F51C3: glsl_to_tgsi_visitor::visit(ir_assignment*) 
(st_glsl_to_tgsi.cpp:2932)
==24131==by 0xB5E45D3: glsl_to_tgsi_visitor::visit(ir_function*) 
(st_glsl_to_tgsi.cpp:1185)
==24131==by 0xB6BD2D0: visit_exec_list(exec_list*, ir_visitor*) 
(ir.cpp:1900)

==24131==by 0xB5FE312: get_mesa_program_tgsi (st_glsl_to_tgsi.cpp:6559)
==24131==by 0xB5FE312: st_link_shader (st_glsl_to_tgsi.cpp:6906)
==24131==by 0xB622A0F: _mesa_glsl_link_shader (ir_to_mesa.cpp:3118)
==24131==by 0xB52D7CA: link_program (shaderapi.c:1171)
==24131==by 0xB52D7CA: link_program_error (shaderapi.c:1249)
==24131==by 0x4F0B65A: stub_glLinkProgram (piglit-dispatch-gen.c:33822)
==24131==by 0x407A67: link_and_use_shaders (shader_runner.c:1086)
==24131==by 0x410601: init_test (shader_runner.c:3855)


Tim

On 13/09/17 02:41, Ian Romanick wrote:

From: Ian Romanick 

glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, 
_mesa_glsl_parse_state*, const ast_type_qualifier&, const ast_type_qualifier&)’:
glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ [-Wunused-parameter]
  merge_bindless_qualifier(YYLTYPE *loc,
^~~
glsl/ast_type.cpp:191:52: warning: unused parameter ‘qualifier’ 
[-Wunused-parameter]
   const ast_type_qualifier ,
 ^
glsl/ast_type.cpp:192:52: warning: unused parameter ‘new_qualifier’ 
[-Wunused-parameter]
   const ast_type_qualifier _qualifier)
 ^

glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_rvalue::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:512:44: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
  ir_rvalue::constant_expression_value(void *mem_ctx, struct hash_table *)
 ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_texture::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:705:45: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
  ir_texture::constant_expression_value(void *mem_ctx, struct hash_table *)
  ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_assignment::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:851:48: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
  ir_assignment::constant_expression_value(void *mem_ctx, struct hash_table *)
 ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_constant::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:859:46: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
  ir_constant::constant_expression_value(void *mem_ctx, struct hash_table *)
   ^~~

glsl/linker.cpp: In function ‘void 
link_xfb_stride_layout_qualifiers(gl_context*, gl_shader_program*, 
gl_linked_shader*, gl_shader**, unsigned int)’:
glsl/linker.cpp:1655:60: warning: unused parameter ‘linked_shader’ 
[-Wunused-parameter]
struct gl_linked_shader *linked_shader,
 ^
glsl/linker.cpp: In function ‘void 
link_bindless_layout_qualifiers(gl_shader_program*, gl_program*, gl_shader**, 
unsigned int)’:
glsl/linker.cpp:1693:52: warning: unused parameter ‘gl_prog’ 
[-Wunused-parameter]
  struct gl_program *gl_prog,
 ^~~

glsl/lower_distance.cpp: In member function ‘virtual void 
{anonymous}::lower_distance_visitor_counter::handle_rvalue(ir_rvalue**)’:
glsl/lower_distance.cpp:652:59: warning: unused parameter ‘rv’ 
[-Wunused-parameter]
  lower_distance_visitor_counter::handle_rvalue(ir_rvalue **rv)
^~

glsl/opt_array_splitting.cpp: In member function ‘virtual

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-13 Thread tournier.elie 
On 13 September 2017 at 13:13, Alejandro Piñeiro  wrote:
> Series:
> Reviewed-by: Alejandro Piñeiro 

FWIW
Reviewed-by: Elie Tournier 
>
> On 12/09/17 18:41, Ian Romanick wrote:
>> From: Ian Romanick 
>>
>> glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, 
>> _mesa_glsl_parse_state*, const ast_type_qualifier&, const 
>> ast_type_qualifier&)’:
>> glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ 
>> [-Wunused-parameter]
>>  merge_bindless_qualifier(YYLTYPE *loc,
>>^~~
>> glsl/ast_type.cpp:191:52: warning: unused parameter ‘qualifier’ 
>> [-Wunused-parameter]
>>   const ast_type_qualifier ,
>> ^
>> glsl/ast_type.cpp:192:52: warning: unused parameter ‘new_qualifier’ 
>> [-Wunused-parameter]
>>   const ast_type_qualifier _qualifier)
>> ^
>>
>> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
>> ir_rvalue::constant_expression_value(void*, hash_table*)’:
>> glsl/ir_constant_expression.cpp:512:44: warning: unused parameter ‘mem_ctx’ 
>> [-Wunused-parameter]
>>  ir_rvalue::constant_expression_value(void *mem_ctx, struct hash_table *)
>> ^~~
>> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
>> ir_texture::constant_expression_value(void*, hash_table*)’:
>> glsl/ir_constant_expression.cpp:705:45: warning: unused parameter ‘mem_ctx’ 
>> [-Wunused-parameter]
>>  ir_texture::constant_expression_value(void *mem_ctx, struct hash_table *)
>>  ^~~
>> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
>> ir_assignment::constant_expression_value(void*, hash_table*)’:
>> glsl/ir_constant_expression.cpp:851:48: warning: unused parameter ‘mem_ctx’ 
>> [-Wunused-parameter]
>>  ir_assignment::constant_expression_value(void *mem_ctx, struct hash_table *)
>> ^~~
>> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
>> ir_constant::constant_expression_value(void*, hash_table*)’:
>> glsl/ir_constant_expression.cpp:859:46: warning: unused parameter ‘mem_ctx’ 
>> [-Wunused-parameter]
>>  ir_constant::constant_expression_value(void *mem_ctx, struct hash_table *)
>>   ^~~
>>
>> glsl/linker.cpp: In function ‘void 
>> link_xfb_stride_layout_qualifiers(gl_context*, gl_shader_program*, 
>> gl_linked_shader*, gl_shader**, unsigned int)’:
>> glsl/linker.cpp:1655:60: warning: unused parameter ‘linked_shader’ 
>> [-Wunused-parameter]
>>struct gl_linked_shader *linked_shader,
>> ^
>> glsl/linker.cpp: In function ‘void 
>> link_bindless_layout_qualifiers(gl_shader_program*, gl_program*, 
>> gl_shader**, unsigned int)’:
>> glsl/linker.cpp:1693:52: warning: unused parameter ‘gl_prog’ 
>> [-Wunused-parameter]
>>  struct gl_program *gl_prog,
>> ^~~
>>
>> glsl/lower_distance.cpp: In member function ‘virtual void 
>> {anonymous}::lower_distance_visitor_counter::handle_rvalue(ir_rvalue**)’:
>> glsl/lower_distance.cpp:652:59: warning: unused parameter ‘rv’ 
>> [-Wunused-parameter]
>>  lower_distance_visitor_counter::handle_rvalue(ir_rvalue **rv)
>>^~
>>
>> glsl/opt_array_splitting.cpp: In member function ‘virtual ir_visitor_status 
>> {anonymous}::ir_array_reference_visitor::visit_leave(ir_assignment*)’:
>> glsl/opt_array_splitting.cpp:198:56: warning: unused parameter ‘ir’ 
>> [-Wunused-parameter]
>>  ir_array_reference_visitor::visit_leave(ir_assignment *ir)
>> ^~
>>
>> glsl/glsl_parser_extras.cpp: In function ‘void 
>> assign_subroutine_indexes(gl_shader*, _mesa_glsl_parse_state*)’:
>> glsl/glsl_parser_extras.cpp:1869:45: warning: unused parameter ‘sh’ 
>> [-Wunused-parameter]
>>  assign_subroutine_indexes(struct gl_shader *sh,
>>  ^~
>>
>> Signed-off-by: Ian Romanick 
>> ---
>>  src/compiler/glsl/ast_type.cpp   | 7 ++-
>>  src/compiler/glsl/glsl_parser_extras.cpp | 5 ++---
>>  src/compiler/glsl/ir_constant_expression.cpp | 8 
>>  src/compiler/glsl/linker.cpp | 7 ++-
>>  src/compiler/glsl/lower_distance.cpp | 2 +-
>>  src/compiler/glsl/opt_array_splitting.cpp| 2 +-
>>  6 files changed, 12 insertions(+), 19 deletions(-)
>>
>> diff --git a/src/compiler/glsl/ast_type.cpp

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-13 Thread Alejandro Piñeiro 
Series:
Reviewed-by: Alejandro Piñeiro 

On 12/09/17 18:41, Ian Romanick wrote:
> From: Ian Romanick 
>
> glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, 
> _mesa_glsl_parse_state*, const ast_type_qualifier&, const 
> ast_type_qualifier&)’:
> glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ [-Wunused-parameter]
>  merge_bindless_qualifier(YYLTYPE *loc,
>^~~
> glsl/ast_type.cpp:191:52: warning: unused parameter ‘qualifier’ 
> [-Wunused-parameter]
>   const ast_type_qualifier ,
> ^
> glsl/ast_type.cpp:192:52: warning: unused parameter ‘new_qualifier’ 
> [-Wunused-parameter]
>   const ast_type_qualifier _qualifier)
> ^
>
> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
> ir_rvalue::constant_expression_value(void*, hash_table*)’:
> glsl/ir_constant_expression.cpp:512:44: warning: unused parameter ‘mem_ctx’ 
> [-Wunused-parameter]
>  ir_rvalue::constant_expression_value(void *mem_ctx, struct hash_table *)
> ^~~
> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
> ir_texture::constant_expression_value(void*, hash_table*)’:
> glsl/ir_constant_expression.cpp:705:45: warning: unused parameter ‘mem_ctx’ 
> [-Wunused-parameter]
>  ir_texture::constant_expression_value(void *mem_ctx, struct hash_table *)
>  ^~~
> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
> ir_assignment::constant_expression_value(void*, hash_table*)’:
> glsl/ir_constant_expression.cpp:851:48: warning: unused parameter ‘mem_ctx’ 
> [-Wunused-parameter]
>  ir_assignment::constant_expression_value(void *mem_ctx, struct hash_table *)
> ^~~
> glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
> ir_constant::constant_expression_value(void*, hash_table*)’:
> glsl/ir_constant_expression.cpp:859:46: warning: unused parameter ‘mem_ctx’ 
> [-Wunused-parameter]
>  ir_constant::constant_expression_value(void *mem_ctx, struct hash_table *)
>   ^~~
>
> glsl/linker.cpp: In function ‘void 
> link_xfb_stride_layout_qualifiers(gl_context*, gl_shader_program*, 
> gl_linked_shader*, gl_shader**, unsigned int)’:
> glsl/linker.cpp:1655:60: warning: unused parameter ‘linked_shader’ 
> [-Wunused-parameter]
>struct gl_linked_shader *linked_shader,
> ^
> glsl/linker.cpp: In function ‘void 
> link_bindless_layout_qualifiers(gl_shader_program*, gl_program*, gl_shader**, 
> unsigned int)’:
> glsl/linker.cpp:1693:52: warning: unused parameter ‘gl_prog’ 
> [-Wunused-parameter]
>  struct gl_program *gl_prog,
> ^~~
>
> glsl/lower_distance.cpp: In member function ‘virtual void 
> {anonymous}::lower_distance_visitor_counter::handle_rvalue(ir_rvalue**)’:
> glsl/lower_distance.cpp:652:59: warning: unused parameter ‘rv’ 
> [-Wunused-parameter]
>  lower_distance_visitor_counter::handle_rvalue(ir_rvalue **rv)
>^~
>
> glsl/opt_array_splitting.cpp: In member function ‘virtual ir_visitor_status 
> {anonymous}::ir_array_reference_visitor::visit_leave(ir_assignment*)’:
> glsl/opt_array_splitting.cpp:198:56: warning: unused parameter ‘ir’ 
> [-Wunused-parameter]
>  ir_array_reference_visitor::visit_leave(ir_assignment *ir)
> ^~
>
> glsl/glsl_parser_extras.cpp: In function ‘void 
> assign_subroutine_indexes(gl_shader*, _mesa_glsl_parse_state*)’:
> glsl/glsl_parser_extras.cpp:1869:45: warning: unused parameter ‘sh’ 
> [-Wunused-parameter]
>  assign_subroutine_indexes(struct gl_shader *sh,
>  ^~
>
> Signed-off-by: Ian Romanick 
> ---
>  src/compiler/glsl/ast_type.cpp   | 7 ++-
>  src/compiler/glsl/glsl_parser_extras.cpp | 5 ++---
>  src/compiler/glsl/ir_constant_expression.cpp | 8 
>  src/compiler/glsl/linker.cpp | 7 ++-
>  src/compiler/glsl/lower_distance.cpp | 2 +-
>  src/compiler/glsl/opt_array_splitting.cpp| 2 +-
>  6 files changed, 12 insertions(+), 19 deletions(-)
>
> diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp
> index ee8697b..e9d60de 100644
> --- a/src/compiler/glsl/ast_type.cpp
> +++ b/src/compiler/glsl/ast_type.cpp
> @@ -186,10 +186,7 @@ validate_point_mode(MAYBE_UNUSED const 
> ast_type_qualifier ,
>  }
>  
>  static void
>

[Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-12 Thread Ian Romanick 
From: Ian Romanick 

glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, 
_mesa_glsl_parse_state*, const ast_type_qualifier&, const ast_type_qualifier&)’:
glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ [-Wunused-parameter]
 merge_bindless_qualifier(YYLTYPE *loc,
   ^~~
glsl/ast_type.cpp:191:52: warning: unused parameter ‘qualifier’ 
[-Wunused-parameter]
  const ast_type_qualifier ,
^
glsl/ast_type.cpp:192:52: warning: unused parameter ‘new_qualifier’ 
[-Wunused-parameter]
  const ast_type_qualifier _qualifier)
^

glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_rvalue::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:512:44: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
 ir_rvalue::constant_expression_value(void *mem_ctx, struct hash_table *)
^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_texture::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:705:45: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
 ir_texture::constant_expression_value(void *mem_ctx, struct hash_table *)
 ^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_assignment::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:851:48: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
 ir_assignment::constant_expression_value(void *mem_ctx, struct hash_table *)
^~~
glsl/ir_constant_expression.cpp: In member function ‘virtual ir_constant* 
ir_constant::constant_expression_value(void*, hash_table*)’:
glsl/ir_constant_expression.cpp:859:46: warning: unused parameter ‘mem_ctx’ 
[-Wunused-parameter]
 ir_constant::constant_expression_value(void *mem_ctx, struct hash_table *)
  ^~~

glsl/linker.cpp: In function ‘void 
link_xfb_stride_layout_qualifiers(gl_context*, gl_shader_program*, 
gl_linked_shader*, gl_shader**, unsigned int)’:
glsl/linker.cpp:1655:60: warning: unused parameter ‘linked_shader’ 
[-Wunused-parameter]
   struct gl_linked_shader *linked_shader,
^
glsl/linker.cpp: In function ‘void 
link_bindless_layout_qualifiers(gl_shader_program*, gl_program*, gl_shader**, 
unsigned int)’:
glsl/linker.cpp:1693:52: warning: unused parameter ‘gl_prog’ 
[-Wunused-parameter]
 struct gl_program *gl_prog,
^~~

glsl/lower_distance.cpp: In member function ‘virtual void 
{anonymous}::lower_distance_visitor_counter::handle_rvalue(ir_rvalue**)’:
glsl/lower_distance.cpp:652:59: warning: unused parameter ‘rv’ 
[-Wunused-parameter]
 lower_distance_visitor_counter::handle_rvalue(ir_rvalue **rv)
   ^~

glsl/opt_array_splitting.cpp: In member function ‘virtual ir_visitor_status 
{anonymous}::ir_array_reference_visitor::visit_leave(ir_assignment*)’:
glsl/opt_array_splitting.cpp:198:56: warning: unused parameter ‘ir’ 
[-Wunused-parameter]
 ir_array_reference_visitor::visit_leave(ir_assignment *ir)
^~

glsl/glsl_parser_extras.cpp: In function ‘void 
assign_subroutine_indexes(gl_shader*, _mesa_glsl_parse_state*)’:
glsl/glsl_parser_extras.cpp:1869:45: warning: unused parameter ‘sh’ 
[-Wunused-parameter]
 assign_subroutine_indexes(struct gl_shader *sh,
 ^~

Signed-off-by: Ian Romanick 
---
 src/compiler/glsl/ast_type.cpp   | 7 ++-
 src/compiler/glsl/glsl_parser_extras.cpp | 5 ++---
 src/compiler/glsl/ir_constant_expression.cpp | 8 
 src/compiler/glsl/linker.cpp | 7 ++-
 src/compiler/glsl/lower_distance.cpp | 2 +-
 src/compiler/glsl/opt_array_splitting.cpp| 2 +-
 6 files changed, 12 insertions(+), 19 deletions(-)

diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp
index ee8697b..e9d60de 100644
--- a/src/compiler/glsl/ast_type.cpp
+++ b/src/compiler/glsl/ast_type.cpp
@@ -186,10 +186,7 @@ validate_point_mode(MAYBE_UNUSED const ast_type_qualifier 
,
 }
 
 static void
-merge_bindless_qualifier(YYLTYPE *loc,
- _mesa_glsl_parse_state *state,
- const ast_type_qualifier ,
- const ast_type_qualifier _qualifier)
+merge_bindless_qualifier(_mesa_glsl_parse_state *state)
 {
if