Re: [Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

2016-10-28 Thread Eric Engestrom 
On Wednesday, 2016-09-14 14:06:18 -0400, Adam Jackson wrote:
> Signed-off-by: Adam Jackson 
> ---

It has been pointed out recently [1] that this series hasn't landed yet.
Has it simply fallen through the cracks, or is something holding it up?

Cheers,
  Eric

[1] https://bugs.freedesktop.org/show_bug.cgi?id=92877

>  src/glx/glxglvnd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c
> index 098304d..2fc9b00 100644
> --- a/src/glx/glxglvnd.c
> +++ b/src/glx/glxglvnd.c
> @@ -50,6 +50,9 @@ static void __glXGLVNDSetDispatchIndex(const GLubyte 
> *procName, int index)
>  {
>  unsigned internalIndex = FindGLXFunction(procName);
>  
> +if (internalIndex == DI_FUNCTION_COUNT)
> +return; /* unknown or static dispatch */
> +
>  __glXDispatchTableIndices[internalIndex] = index;
>  }
>  
> -- 
> 2.9.3
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

2016-09-15 Thread Eric Engestrom 
On Wed, Sep 14, 2016 at 02:06:18PM -0400, Adam Jackson wrote:
> Signed-off-by: Adam Jackson 

The series is:
Reviewed-by: Eric Engestrom 

BTW, I feel like these should be CC'ed to stable? I never know when
a fix is stable-worthy.

Cheers,
  Eric

> ---
>  src/glx/glxglvnd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c
> index 098304d..2fc9b00 100644
> --- a/src/glx/glxglvnd.c
> +++ b/src/glx/glxglvnd.c
> @@ -50,6 +50,9 @@ static void __glXGLVNDSetDispatchIndex(const GLubyte 
> *procName, int index)
>  {
>  unsigned internalIndex = FindGLXFunction(procName);
>  
> +if (internalIndex == DI_FUNCTION_COUNT)
> +return; /* unknown or static dispatch */
> +
>  __glXDispatchTableIndices[internalIndex] = index;
>  }
>  
> -- 
> 2.9.3
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

2016-09-14 Thread Adam Jackson 
Signed-off-by: Adam Jackson 
---
 src/glx/glxglvnd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c
index 098304d..2fc9b00 100644
--- a/src/glx/glxglvnd.c
+++ b/src/glx/glxglvnd.c
@@ -50,6 +50,9 @@ static void __glXGLVNDSetDispatchIndex(const GLubyte 
*procName, int index)
 {
 unsigned internalIndex = FindGLXFunction(procName);
 
+if (internalIndex == DI_FUNCTION_COUNT)
+return; /* unknown or static dispatch */
+
 __glXDispatchTableIndices[internalIndex] = index;
 }
 
-- 
2.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev