Re: [Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

[Samuel Iglesias Gonsálvez]

Reviewed-by: Samuel Iglesias Gonsálvez 

On Tue, 2016-01-12 at 20:34 +1100, Timothy Arceri wrote:
> I don't think this will do much as it's a compiler error
> to use component without location which is already in the
> table but its good to be consistent.
> ---
>  src/glsl/ast_type.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index 7330a34..6d6f88f 100644
> --- a/src/glsl/ast_type.cpp
> +++ b/src/glsl/ast_type.cpp
> @@ -73,6 +73,7 @@ ast_type_qualifier::has_layout() const
>    || this->flags.q.column_major
>    || this->flags.q.row_major
>    || this->flags.q.packed
> +  || this->flags.q.explicit_component
>    || this->flags.q.explicit_location
>    || this->flags.q.explicit_index
>    || this->flags.q.explicit_binding

signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

[Ian Romanick]

Patches 1, 2, and 4 are

Reviewed-by: Ian Romanick 

Pending the result of the Khronos spec bug, patch 3 is also R-b.

On 01/12/2016 01:34 AM, Timothy Arceri wrote:
> I don't think this will do much as it's a compiler error
> to use component without location which is already in the
> table but its good to be consistent.
> ---
>  src/glsl/ast_type.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index 7330a34..6d6f88f 100644
> --- a/src/glsl/ast_type.cpp
> +++ b/src/glsl/ast_type.cpp
> @@ -73,6 +73,7 @@ ast_type_qualifier::has_layout() const
>|| this->flags.q.column_major
>|| this->flags.q.row_major
>|| this->flags.q.packed
> +  || this->flags.q.explicit_component
>|| this->flags.q.explicit_location
>|| this->flags.q.explicit_index
>|| this->flags.q.explicit_binding
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

[Timothy Arceri]

I don't think this will do much as it's a compiler error
to use component without location which is already in the
table but its good to be consistent.
---
 src/glsl/ast_type.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
index 7330a34..6d6f88f 100644
--- a/src/glsl/ast_type.cpp
+++ b/src/glsl/ast_type.cpp
@@ -73,6 +73,7 @@ ast_type_qualifier::has_layout() const
   || this->flags.q.column_major
   || this->flags.q.row_major
   || this->flags.q.packed
+  || this->flags.q.explicit_component
   || this->flags.q.explicit_location
   || this->flags.q.explicit_index
   || this->flags.q.explicit_binding
-- 
2.4.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev