Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-18 Thread Jason Ekstrand 
Thanks for the sandy bridge doc link.  With all of the extra MBZ removed,
this patch is

Reviewed-by: Jason Ekstrand 

On Mon, Oct 17, 2016 at 11:39 AM, Lionel Landwerlin 
wrote:

> On Mon, 2016-10-17 at 10:56 -0700, Jason Ekstrand wrote:
> >
> >
> > On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin  > .com> wrote:
> > > Signed-off-by: Lionel Landwerlin 
> > > ---
> > >  src/intel/genxml/gen6.xml  | 32 
> > >  src/intel/genxml/gen7.xml  | 12 
> > >  src/intel/genxml/gen75.xml | 40
> > > 
> > >  src/intel/genxml/gen8.xml  | 12 
> > >  src/intel/genxml/gen9.xml  | 12 
> > >  5 files changed, 108 insertions(+)
> > >
> > > diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
> > > index 211716b..7ba8954 100644
> > > --- a/src/intel/genxml/gen6.xml
> > > +++ b/src/intel/genxml/gen6.xml
> > > @@ -372,6 +372,38 @@
> > >  
> > >
> > >
> > > +  
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > +
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > +
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > +
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > +
> > > + > > type="int"/>
> > > + > > type="int"/>
> > > + > > type="int"/>
> > > + > > type="int"/>
> > > +
> > > + > > type="int"/>
> > > + > > type="int"/>
> > > + > > type="int"/>
> > > + > > type="int"/>
> > > +  
> >
> > Are there docs for this anywhere or did you just pull it out of the
> > gen6 GL code?
> >
>
> Yes, there are but indeed not in the PRMs.
>
>
> > > +
> > >
> > >   > > type="bool"/>
> > >   > > type="uint">
> > > diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
> > > index eabb244..a950603 100644
> > > --- a/src/intel/genxml/gen7.xml
> > > +++ b/src/intel/genxml/gen7.xml
> > > @@ -428,6 +428,18 @@
> > >   > > type="u4.8"/>
> > >
> > >
> > > +  
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > +
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > +  
> > > +
> > >
> > >   > > type="bool"/>
> > >   > > type="uint">
> > > diff --git a/src/intel/genxml/gen75.xml
> > > b/src/intel/genxml/gen75.xml
> > > index 27a12cb..42f66cb 100644
> > > --- a/src/intel/genxml/gen75.xml
> > > +++ b/src/intel/genxml/gen75.xml
> > > @@ -438,6 +438,46 @@
> > >   > > type="u4.8"/>
> > >
> > >
> > > +  
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > +
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> >
> > In the rest of the XML, MBZ fields simply don't exist.  The packing
> > functions will automatically zero anything that doesn't have data in
> > it.  I'm not sure if that's true for whole dwords but if it's not, we
> > should fix that.  In other words, I believe the correct solution is
> > to just delete these and let "Border Color 8bit Red" start super-late
> > in the packet.
> >
> > > +
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > end="575" type="uint"/>
> > > + > > end="607" type="uint"/>
> > > + > > end="639" type="uint"/>
> >
> > These can go as well
> >
> > > +
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > end="575" type="uint"/>
> >
> > and this
> >
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > end="639" type="uint"/>
> >
> > and this
> >
> > > +
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > + > > type="uint"/>
> > > +  
> > > +
> > >
> > >   > > type="bool"/>
> > >   > > type="uint">
> > > diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
> > > index ee62614..a281f01 100644
> > > --- a/src/intel/genxml/gen8.xml
> > > +++ b/src/intel/genxml/gen8.xml
> > > @@ -358,6 +358,18 @@
> > >   > > type="s1.6"/>
> > >
> > >
> > > +  
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > + > > type="float"/>
> > > +
> > > + > >

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Lionel Landwerlin 
On Mon, 2016-10-17 at 10:56 -0700, Jason Ekstrand wrote:
> 
> 
> On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin  .com> wrote:
> > Signed-off-by: Lionel Landwerlin 
> > ---
> >  src/intel/genxml/gen6.xml  | 32 
> >  src/intel/genxml/gen7.xml  | 12 
> >  src/intel/genxml/gen75.xml | 40
> > 
> >  src/intel/genxml/gen8.xml  | 12 
> >  src/intel/genxml/gen9.xml  | 12 
> >  5 files changed, 108 insertions(+)
> > 
> > diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
> > index 211716b..7ba8954 100644
> > --- a/src/intel/genxml/gen6.xml
> > +++ b/src/intel/genxml/gen6.xml
> > @@ -372,6 +372,38 @@
> >      
> >    
> > 
> > +  
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +
> > +     > type="int"/>
> > +     > type="int"/>
> > +     > type="int"/>
> > +     > type="int"/>
> > +
> > +     > type="int"/>
> > +     > type="int"/>
> > +     > type="int"/>
> > +     > type="int"/>
> > +  
> 
> Are there docs for this anywhere or did you just pull it out of the
> gen6 GL code?
> 
 
Yes, there are but indeed not in the PRMs.


> > +
> >    
> >       > type="bool"/>
> >       > type="uint">
> > diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
> > index eabb244..a950603 100644
> > --- a/src/intel/genxml/gen7.xml
> > +++ b/src/intel/genxml/gen7.xml
> > @@ -428,6 +428,18 @@
> >       > type="u4.8"/>
> >    
> > 
> > +  
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +  
> > +
> >    
> >       > type="bool"/>
> >       > type="uint">
> > diff --git a/src/intel/genxml/gen75.xml
> > b/src/intel/genxml/gen75.xml
> > index 27a12cb..42f66cb 100644
> > --- a/src/intel/genxml/gen75.xml
> > +++ b/src/intel/genxml/gen75.xml
> > @@ -438,6 +438,46 @@
> >       > type="u4.8"/>
> >    
> > 
> > +  
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> 
> In the rest of the XML, MBZ fields simply don't exist.  The packing
> functions will automatically zero anything that doesn't have data in
> it.  I'm not sure if that's true for whole dwords but if it's not, we
> should fix that.  In other words, I believe the correct solution is
> to just delete these and let "Border Color 8bit Red" start super-late 
> in the packet.
>  
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > end="575" type="uint"/>
> > +     > end="607" type="uint"/>
> > +     > end="639" type="uint"/>
> 
> These can go as well
>  
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > end="575" type="uint"/>
> 
> and this
>  
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > end="639" type="uint"/>
> 
> and this
>  
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +  
> > +
> >    
> >       > type="bool"/>
> >       > type="uint">
> > diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
> > index ee62614..a281f01 100644
> > --- a/src/intel/genxml/gen8.xml
> > +++ b/src/intel/genxml/gen8.xml
> > @@ -358,6 +358,18 @@
> >       > type="s1.6"/>
> >    
> > 
> > +  
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +  
> > +
> >    
> >       > type="bool"/>
> >       > type="uint">
> > diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml
> > index 9c81c5a..665b61f 100644
> > --- a/src/intel/genxml/gen9.xml
> > +++ b/src/intel/genxml/gen9.xml
> > @@ -382,6 +382,18 @@
> >       > type="s1.6"/>
> >    
> > 
> > +  
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +     > type="float"/>
> > +
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +     > type="uint"/>
> > +  
> > +
> >    
> >       > type="bool"/>
> >       >

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Jason Ekstrand 
On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin 
wrote:

> Signed-off-by: Lionel Landwerlin 
> ---
>  src/intel/genxml/gen6.xml  | 32 
>  src/intel/genxml/gen7.xml  | 12 
>  src/intel/genxml/gen75.xml | 40 
>  src/intel/genxml/gen8.xml  | 12 
>  src/intel/genxml/gen9.xml  | 12 
>  5 files changed, 108 insertions(+)
>
> diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
> index 211716b..7ba8954 100644
> --- a/src/intel/genxml/gen6.xml
> +++ b/src/intel/genxml/gen6.xml
> @@ -372,6 +372,38 @@
>  
>
>
> +  
> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +
> + type="float"/>
> + type="float"/>
> + type="float"/>
> + type="float"/>
> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +
> + type="int"/>
> + type="int"/>
> + type="int"/>
> + type="int"/>
> +
> + type="int"/>
> + type="int"/>
> + type="int"/>
> + type="int"/>
> +  
>

Are there docs for this anywhere or did you just pull it out of the gen6 GL
code?


> +
>
>  
>   type="uint">
> diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
> index eabb244..a950603 100644
> --- a/src/intel/genxml/gen7.xml
> +++ b/src/intel/genxml/gen7.xml
> @@ -428,6 +428,18 @@
>  
>
>
> +  
> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +
> +
> + type="float"/>
> + type="float"/>
> + type="float"/>
> +  
> +
>
>  
>   type="uint">
> diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
> index 27a12cb..42f66cb 100644
> --- a/src/intel/genxml/gen75.xml
> +++ b/src/intel/genxml/gen75.xml
> @@ -438,6 +438,46 @@
>  
>
>
> +  
> +
> + type="float"/>
> + type="float"/>
> + type="float"/>
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
>

In the rest of the XML, MBZ fields simply don't exist.  The packing
functions will automatically zero anything that doesn't have data in it.
I'm not sure if that's true for whole dwords but if it's not, we should fix
that.  In other words, I believe the correct solution is to just delete
these and let "Border Color 8bit Red" start super-late in the packet.


> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
>

These can go as well


> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
>

and this


> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
>

and this


> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +  
> +
>
>  
>   type="uint">
> diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
> index ee62614..a281f01 100644
> --- a/src/intel/genxml/gen8.xml
> +++ b/src/intel/genxml/gen8.xml
> @@ -358,6 +358,18 @@
>  
>
>
> +  
> +
> + type="float"/>
> + type="float"/>
> + type="float"/>
> +
> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +  
> +
>
>  
>   type="uint">
> diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml
> index 9c81c5a..665b61f 100644
> --- a/src/intel/genxml/gen9.xml
> +++ b/src/intel/genxml/gen9.xml
> @@ -382,6 +382,18 @@
>  
>
>
> +  
> +
> + type="float"/>
> + type="float"/>
> + type="float"/>
> +
> +
> + type="uint"/>
> + type="uint"/>
> + type="uint"/>
> +  
> +
>
>  
>   type="uint">
> --
> 2.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Lionel Landwerlin 
Signed-off-by: Lionel Landwerlin 
---
 src/intel/genxml/gen6.xml  | 32 
 src/intel/genxml/gen7.xml  | 12 
 src/intel/genxml/gen75.xml | 40 
 src/intel/genxml/gen8.xml  | 12 
 src/intel/genxml/gen9.xml  | 12 
 5 files changed, 108 insertions(+)

diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
index 211716b..7ba8954 100644
--- a/src/intel/genxml/gen6.xml
+++ b/src/intel/genxml/gen6.xml
@@ -372,6 +372,38 @@
 
   
 
+  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+  
+
   
 
 
diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
index eabb244..a950603 100644
--- a/src/intel/genxml/gen7.xml
+++ b/src/intel/genxml/gen7.xml
@@ -428,6 +428,18 @@
 
   
 
+  
+
+
+
+
+
+
+
+
+
+  
+
   
 
 
diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
index 27a12cb..42f66cb 100644
--- a/src/intel/genxml/gen75.xml
+++ b/src/intel/genxml/gen75.xml
@@ -438,6 +438,46 @@
 
   
 
+  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+  
+
   
 
 
diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
index ee62614..a281f01 100644
--- a/src/intel/genxml/gen8.xml
+++ b/src/intel/genxml/gen8.xml
@@ -358,6 +358,18 @@
 
   
 
+  
+
+
+
+
+
+
+
+
+
+  
+
   
 
 
diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml
index 9c81c5a..665b61f 100644
--- a/src/intel/genxml/gen9.xml
+++ b/src/intel/genxml/gen9.xml
@@ -382,6 +382,18 @@
 
   
 
+  
+
+
+
+
+
+
+
+
+
+  
+
   
 
 
-- 
2.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev